Realtime pipeline public preview #15525
Conversation
Co-authored-by: wu-hui <[email protected]> Co-authored-by: Nick Cooke <[email protected]>
Co-authored-by: wu-hui <[email protected]> Co-authored-by: Nick Cooke <[email protected]>
Co-authored-by: wu-hui <[email protected]> Co-authored-by: Nick Cooke <[email protected]>
Co-authored-by: Morgan Chen <[email protected]>
…ode/` directory (#14833) Co-authored-by: Morgan Chen <[email protected]>
…ervice/` directory (#14839) Co-authored-by: Morgan Chen <[email protected]>
Co-authored-by: Morgan Chen <[email protected]>
…xpressions/BooleanExpression.swift Co-authored-by: gemini-code-assist[bot] <176961590+gemini-code-assist[bot]@users.noreply.github.com>
…xpressions/BooleanExpression.swift Co-authored-by: gemini-code-assist[bot] <176961590+gemini-code-assist[bot]@users.noreply.github.com>
cherylEnkidu
changed the base branch from
feat/pipeline/private-preview
to
cheryl/AddExprAsBool
|
/gemini review |
![gemini-code-assist[bot]](https://avatars.githubusercontent.com/in/956858?s=60&v=4){kind=small}
There was a problem hiding this comment.
Code Review
This pull request makes the realtime pipeline feature public. This involves changing several Swift APIs from internal to public and includes a significant, well-structured refactoring of the C++ expression evaluation logic. The new create(from: Query) function is a great addition for converting standard queries to pipelines.
My main feedback is to improve the safety of the new create(from:) method in RealtimePipelineSource.swift by replacing forced casts and fatalError with proper error handling, which is crucial for a public API. I also found a minor typo in a new test name.
The C++ refactoring is a great improvement, making the expression evaluation logic more modular and readable. The renaming of functions like lt to less_than and eq to equal enhances clarity.
Overall, this is a solid PR that makes a powerful feature available to users.
Co-authored-by: gemini-code-assist[bot] <176961590+gemini-code-assist[bot]@users.noreply.github.com>
17 participants
No description provided.