[FirebaseAI] Move ProgressOverlay to GenerativeAIUIComponents #1736
Conversation
![gemini-code-assist[bot]](https://avatars.githubusercontent.com/in/956858?s=60&v=4){kind=small}
There was a problem hiding this comment.
Summary of Changes
Hello @YoungHypo, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!
This pull request focuses on improving the modularity and reusability of UI components within the FirebaseAI project. I've extracted a common loading overlay component into a shared UI module, which will streamline future development by providing a unified progress indication mechanism.
Highlights
- Component Relocation: I've moved the
ProgressOverlaySwiftUI view fromfirebaseai/ImagenScreen/ImagenScreen.swiftto a new, dedicated file within theGenerativeAIUIComponentsmodule:firebaseai/GenerativeAIUIComponents/Sources/GenerativeAIUIComponents/ProgressOverlay.swift. - Enhanced Reusability: This relocation centralizes the
ProgressOverlaycomponent, making it available for reuse across future generative AI features (e.g., image, video, audio generation) and ensuring a consistent loading UI experience.
Using Gemini Code Assist
The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.
Invoking Gemini
You can request assistance from Gemini at any point in your pull request via creating an issue comment (i.e. comment on the pull request page) using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands.
| Feature | Command | Description |
|---|---|---|
| Code Review | /gemini review |
Performs a code review for the current pull request in its current state. |
| Pull Request Summary | /gemini summary |
Provides a summary of the current pull request in its current state. |
| Comment | @gemini-code-assist | Responds in comments when explicitly tagged, both in issue comments and review comments. |
| Help | /gemini help |
Displays a list of available commands. |
Customization
To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.
Limitations & Feedback
Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments or fill out our survey to provide feedback.
You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension.
Footnotes
-
Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution. ↩
There was a problem hiding this comment.
Code Review
The code changes introduce a new ProgressOverlay view to the GenerativeAIUIComponents library and removes it from ImagenScreen. The review suggests making the text customizable and extracting styling values into constants for better reusability and maintainability.
firebaseai/GenerativeAIUIComponents/Sources/GenerativeAIUIComponents/ProgressOverlay.swift
Outdated
Show resolved
Hide resolved
| Color.black.opacity(0.3) | ||
| .ignoresSafeArea() | ||
|
|
||
| ZStack { | ||
| RoundedRectangle(cornerRadius: 16) | ||
| .fill(Material.ultraThinMaterial) | ||
| .frame(width: 120, height: 100) | ||
| .shadow(radius: 8) |
There was a problem hiding this comment.
The view uses several hardcoded numbers for styling (e.g., 0.3, 16, 120, 100, 8). Extracting these into private static constants will improve readability and make future UI tweaks easier.
private enum Style {
static let backgroundOpacity: CGFloat = 0.3
static let cornerRadius: CGFloat = 16
static let frameWidth: CGFloat = 120
static let frameHeight: CGFloat = 100
static let shadowRadius: CGFloat = 8
static let stackSpacing: CGFloat = 12
static let progressScale: CGFloat = 1.5
}There was a problem hiding this comment.
Is it necessary to extract these styling values into constants, or is it fine to keep them for now?
Although
ProgressOverlayis currently only used in ImageScreen, placed it in GenerativeAIUIComponents to support unified progress indication for future development of image, video, and audio generation features.Related PR. #1719