Skip to content

update ActionCodeSettings snippets #590

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 3 commits into
base: master
Choose a base branch
from
Open

update ActionCodeSettings snippets #590

Show file tree
Hide file tree
Changes from 2 commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
7ec31a7
update ActionCodeSettings snippets
kevinthecheung Oct 22, 2024
f4b6f51
chore: update to firebase-bom 33.9.0
thatfiredev Feb 6, 2025
e70f74f
Merge branch 'master' into kc-email-link
thatfiredev Feb 6, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion auth/app/build.gradle.kts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -40,7 +40,7 @@ dependencies {
implementation("androidx.activity:activity-ktx:1.9.3")

// Import the BoM for the Firebase platform
implementation(platform("com.google.firebase:firebase-bom:33.5.0"))
implementation(platform("com.google.firebase:firebase-bom:33.9.0"))

// Add the dependency for the Firebase Authentication library
// When using the BoM, you don't specify versions in Firebase library dependencies
Expand Down
1 change: 1 addition & 0 deletions auth/app/src/main/java/com/google/firebase/quickstart/auth/MainActivity.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -340,6 +340,7 @@ public void buildActionCodeSettings() {
.setUrl("https://www.example.com/finishSignUp?cartId=1234")
// This must be true
.setHandleCodeInApp(true)
.setLinkDomain("custom-domain.com")
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
.setLinkDomain("custom-domain.com")
// The domain must be configured in Firebase Hosting and owned by the project.
.setLinkDomain("custom-domain.com")

.setIOSBundleId("com.example.ios")
.setAndroidPackageName(
"com.example.android",
Expand Down
1 change: 1 addition & 0 deletions auth/app/src/main/java/com/google/firebase/quickstart/auth/kotlin/MainActivity.kt
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -280,6 +280,7 @@ abstract class MainActivity : AppCompatActivity() {
url = "https://www.example.com/finishSignUp?cartId=1234"
// This must be true
handleCodeInApp = true
setLinkDomain("custom-domain.com")
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
setLinkDomain("custom-domain.com")
// The domain must be configured in Firebase Hosting and owned by the project.
setLinkDomain("custom-domain.com")

setIOSBundleId("com.example.ios")
setAndroidPackageName(
"com.example.android",
Expand Down
Loading