Skip to content

Fix/restrict same name folder creation #143

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 2 commits into
base: main
Choose a base branch
from
Open

Fix/restrict same name folder creation #143

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
6a4c28a
added check to restrict creation of files with same name inside same …
Nick-h4ck3r Nov 3, 2023
e0d6934
added check to restrict creation of files with same name inside same …
Nick-h4ck3r Nov 3, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
16 changes: 15 additions & 1 deletion platform/firecamp-platform/src/components/activity-bar/explorer/menus/CollectionMenu.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -45,7 +45,7 @@ const CollectionMenu = ({
prefix: () => <FolderPlus size={14} />,
name: 'Add Folder',
onClick: () => {
console.log(collectionId, folderId);
// console.log(collectionId, folderId);
if (!platformContext.app.user.isLoggedIn()) {
return platformContext.app.modals.openSignIn();
}
Expand All @@ -64,6 +64,20 @@ const CollectionMenu = ({
};
}
const isValid = Regex.FolderName.test(val);

const existingFolders = useExplorerStore.getState().explorer.folders;
const parentFolderId = folderId || collectionId;
const isDuplicateName = existingFolders.some(
(folder) =>
folder.name === val && folder.__ref.collectionId === parentFolderId
);

if (isDuplicateName) {
return {
isValid: false,
message: 'A folder with the same name already exists in this location.',
};
}
return {
isValid,
message:
Expand Down