refactor(reasm): key reasm FECs by merkle root and rework tile root init #5903
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lidatong
force-pushed
the
chali/refactor/chainer-reasm
branch
3 times, most recently
from
5c983e6 to
e9df86a
Compare
lidatong
changed the title
lidatong
force-pushed
the
chali/refactor/chainer-reasm
branch
from
e9df86a to
8277d64
Compare
lidatong
force-pushed
the
chali/refactor/chainer-reasm
branch
6 times, most recently
from
26a940c to
0772a48
Compare
fd_reasm (formerly fd_fec_chainer) now keys all FEC sets by merkle root. Every FEC set's parent is determined from the chained merkle root tied to every FEC set. Tiles now rely on the manifest sent by snap_out to initialize their root directly instead of relying on fseq set by replay.
lidatong
force-pushed
the
chali/refactor/chainer-reasm
branch
from
0772a48 to
795401b
Compare
emwang-jump
reviewed
Aug 8, 2025
| done for the parent_map - the pool_ele will have an element with key | ||
| slot | fec_set_idx, not UINT_MAX. | ||
|
|
||
| Visually, the parent_map / elements looks like this: |
There was a problem hiding this comment.
i think this parent_map stuff is outdated now
emwang-jump
reviewed
Aug 8, 2025
| fd_histf_sample( ctx->repair->metrics.store_link_wait, (ulong)fd_long_max(shacq_end - shacq_start, 0) ); | ||
| fd_histf_sample( ctx->repair->metrics.store_link_work, (ulong)fd_long_max(shrel_end - shacq_end, 0) ); | ||
|
|
||
| if( FD_UNLIKELY( ctx->shredcap_enabled ) ) { |
There was a problem hiding this comment.
is shredcap disabled with this?
emwang-jump
approved these changes
Aug 8, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fd_reasm (formerly fd_fec_chainer) now keys all FEC sets by merkle root.
Every FEC set's parent is determined from the chained merkle root tied
to every FEC set.