repair: worker pooled async signing and ping-pong optimization #5924
+1,089
−145
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
npatel-jump
requested review from
lidatong,
emwang-jump,
ptaffet-jump and
mmcgee-jump
as code owners
npatel-jump
force-pushed
the
npatel/repair-async-sign-3
branch
from
491ee64 to
4b01600
Compare
npatel-jump
changed the title
npatel-jump
force-pushed
the
npatel/repair-async-sign-3
branch
5 times, most recently
from
68b79d5 to
33da4a0
Compare
npatel-jump
requested review from
0x0ece,
anwayde and
jherrera-jump
as code owners
npatel-jump
force-pushed
the
npatel/repair-async-sign-3
branch
2 times, most recently
from
397187b to
83844d0
Compare
npatel-jump
changed the title
npatel-jump
force-pushed
the
npatel/repair-async-sign-3
branch
from
d84a3f8 to
a3b967e
Compare
lidatong
reviewed
Aug 5, 2025
|
@mmcgee-jump should take a look at changes to sign, shred, pack, bundle (i believe he did some of them) |
lidatong
changed the title
lidatong
changed the title
lidatong
requested changes
Aug 7, 2025
npatel-jump
force-pushed
the
npatel/repair-async-sign-3
branch
7 times, most recently
from
7a1732e to
4220d89
Compare
|
fix above and the |
npatel-jump
force-pushed
the
npatel/repair-async-sign-3
branch
2 times, most recently
from
33811e8 to
a1aa599
Compare
lidatong
approved these changes
Aug 8, 2025
npatel-jump
force-pushed
the
npatel/repair-async-sign-3
branch
from
a1aa599 to
52af559
Compare
lidatong
requested changes
Aug 8, 2025
lidatong
changed the title
npatel-jump
force-pushed
the
npatel/repair-async-sign-3
branch
8 times, most recently
from
8ca1386 to
1d9deff
Compare
lidatong
previously approved these changes
Aug 8, 2025
mmcgee-jump
reviewed
Aug 8, 2025
lidatong
reviewed
Aug 8, 2025
lidatong
reviewed
Aug 8, 2025
Comment on lines
+1
to
+15
| #include "../fd_flamenco_base.h" | ||
| #include "fd_repair.h" | ||
| #include "../../util/fd_util.h" | ||
| #include <string.h> | ||
|
|
||
| /* init repair test */ | ||
| static fd_repair_t * | ||
| test_repair_setup( void ) { | ||
| ulong footprint = fd_repair_footprint(); | ||
| void * shmem = aligned_alloc( fd_repair_align(), footprint ); | ||
| FD_TEST( shmem ); | ||
| fd_repair_t * repair = fd_repair_join( fd_repair_new( shmem, 14919811UL ) ); | ||
| FD_TEST( repair ); | ||
| return repair; | ||
| } |
There was a problem hiding this comment.
it would have been better to track the credits with this API so you can test them together here
There was a problem hiding this comment.
TODO: Will complete this in a seperate PR, going to focus on repair testing subommand for now
npatel-jump
force-pushed
the
npatel/repair-async-sign-3
branch
2 times, most recently
from
1df2a49 to
07bf10e
Compare
Enable asynchronous signing requests in the repair flow. Cleanup and document async repair signing logic. Update for flow control and mapping improvements.
npatel-jump
force-pushed
the
npatel/repair-async-sign-3
branch
from
07bf10e to
d29ba16
Compare
lidatong
approved these changes
Aug 11, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
default.toml - Added minimum sign tiles as 2
config - allow for sign tile count to be parsed
topology - added 2 links: ping pong (sync) and repair requests (async)
repair tile - initialization pending ledger and processing async sign round robin across sign tiles
sign tile - initialization changes to handle links
Decreases repair time per slot from ~280ms per slot to ~50ms per slot