Skip to content

chore: fix wrong fd_pool acquire usage #7057

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
+0 −12
Open

chore: fix wrong fd_pool acquire usage #7057

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 0 additions & 1 deletion src/discof/forest/fd_forest.c
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -175,7 +175,6 @@ fd_forest_init( fd_forest_t * forest, ulong root_slot ) {

/* Sanity checks. */

FD_TEST( root_ele );
FD_TEST( root_ele == fd_forest_frontier_ele_query( frontier, &root_slot, NULL, pool ));
FD_TEST( root_ele->slot == root_slot );

Expand Down
1 change: 0 additions & 1 deletion src/discof/restore/utils/fd_sspeer_selector.c
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -275,7 +275,6 @@ fd_sspeer_selector_add( fd_sspeer_selector_t * selector,
if( FD_UNLIKELY( !peer_pool_free( selector->pool ) ) ) return ULONG_MAX;

peer = peer_pool_ele_acquire( selector->pool );
FD_TEST( peer );
if( FD_LIKELY( ssinfo ) ) {
peer->ssinfo = *ssinfo;
} else {
Expand Down
1 change: 0 additions & 1 deletion src/discof/restore/utils/fd_ssping.c
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -225,7 +225,6 @@ fd_ssping_add( fd_ssping_t * ssping,
if( FD_LIKELY( !peer ) ) {
if( FD_UNLIKELY( !peer_pool_free( ssping->pool ) ) ) return;
peer = peer_pool_ele_acquire( ssping->pool );
FD_TEST( peer );
memset( peer, 0, sizeof(fd_ssping_peer_t) );
peer->refcnt = 0UL;
peer->state = PEER_STATE_UNPINGED;
Expand Down
3 changes: 0 additions & 3 deletions src/flamenco/runtime/fd_bank.c
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -53,9 +53,6 @@ fd_bank_footprint( void ) {
FD_LOG_CRIT(( "Failed to acquire " #name " pool element: pool is full" )); \
} \
fd_bank_##name##_t * child_##name = fd_bank_##name##_pool_ele_acquire( name##_pool ); \
if( FD_UNLIKELY( !child_##name ) ) { \
FD_LOG_CRIT(( "Failed to acquire " #name " pool element" )); \
} \
fd_rwlock_unwrite( fd_bank_get_##name##_pool_lock( bank ) ); \
/* If the dirty flag has not been set yet, we need to allocated a */ \
/* new pool element and copy over the data from the parent idx. */ \
Expand Down
3 changes: 0 additions & 3 deletions src/flamenco/stakes/fd_stake_delegations.c
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -246,9 +246,6 @@ fd_stake_delegations_update( fd_stake_delegations_t * stake_delegations,
}

fd_stake_delegation_t * stake_delegation = fd_stake_delegation_pool_ele_acquire( stake_delegation_pool );
if( FD_UNLIKELY( !stake_delegation ) ) {
FD_LOG_CRIT(( "unable to acquire stake delegation" ));
}

stake_delegation->stake_account = *stake_account;
stake_delegation->vote_account = *vote_account;
Expand Down
3 changes: 0 additions & 3 deletions src/flamenco/stakes/fd_vote_states.c
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -193,9 +193,6 @@ fd_vote_states_update( fd_vote_states_t * vote_states,
}

fd_vote_state_ele_t * vote_state = fd_vote_state_pool_ele_acquire( vote_state_pool );
if( FD_UNLIKELY( !vote_state ) ) {
FD_LOG_CRIT(( "unable to acquire vote state" ));
}

vote_state->vote_account = *vote_account;
vote_state->stake = 0UL;
Expand Down
Loading