Skip to content

runtime: Port Agave 3.1 breaking changes into Firedancer #7131

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Nov 14, 2025
Merged

runtime: Port Agave 3.1 breaking changes into Firedancer #7131

merged 1 commit into from
Nov 14, 2025

Conversation

@cmoyes-jump
Copy link
Contributor

@cmoyes-jump cmoyes-jump commented Nov 7, 2025 •
edited
Loading

NOTE: This will require a test-vectors update.

elf_loader

Solana sbpf loader v0.13.0 updates the version gating logic. The EF_SBPF_V2 special-case and the "force V0 when V0-only" fallback were both removed.

I view this as intentional behavior. This change adopt the same mapping with early UnsupportedSBPFVersion (22) gating, resolving the mismatch.

block

syscall

instr

@cmoyes-jump cmoyes-jump self-assigned this Nov 7, 2025
@github-actions
Copy link

github-actions bot commented Nov 7, 2025

Performance Measurements ⏳

Suite Baseline New Change
backtest mainnet-368528500-perf per slot 0.073565 s 0.072936 s -0.855% ✅
backtest mainnet-368528500-perf snapshot load 2.656 s 2.639 s -0.640% ✅
backtest mainnet-368528500-perf total elapsed 73.56543 s 72.935561 s -0.856% ✅
firedancer mem usage with mainnet.toml 1024.14 GiB 1024.14 GiB 0.000% ✅

mjain-jump
mjain-jump previously approved these changes Nov 7, 2025
View reviewed changes
@github-actions
Copy link

github-actions bot commented Nov 11, 2025

Performance Measurements ⏳

Suite Baseline New Change
backtest mainnet-368528500-perf per slot 0.062424 s 0.051712 s -17.160% ✅
backtest mainnet-368528500-perf snapshot load 2.027 s 1.423 s -29.798% ✅
backtest mainnet-368528500-perf total elapsed 62.424358 s 51.712064 s -17.160% ✅
firedancer mem usage with mainnet.toml 992.14 GiB 992.14 GiB 0.000% ✅

@github-actions
Copy link

github-actions bot commented Nov 11, 2025

Performance Measurements ⏳

Suite Baseline New Change
backtest mainnet-368528500-perf per slot 0.053355 s 0.053095 s -0.487% ✅
backtest mainnet-368528500-perf snapshot load 1.683 s 1.665 s -1.070% ✅
backtest mainnet-368528500-perf total elapsed 53.354876 s 53.095433 s -0.486% ✅
firedancer mem usage with mainnet.toml 992.14 GiB 992.14 GiB 0.000% ✅

@cmoyes-jump cmoyes-jump changed the title runtime: Update ELF loader version mapping runtime: Port Agave 3.1 breaking changes into Firedancer Nov 11, 2025
@github-actions
Copy link

github-actions bot commented Nov 11, 2025

Performance Measurements ⏳

Suite Baseline New Change
backtest mainnet-368528500-perf per slot 0.064257 s 0.064413 s 0.243% ✅
backtest mainnet-368528500-perf snapshot load 2.149 s 2.122 s -1.256% ✅
backtest mainnet-368528500-perf total elapsed 64.25658 s 64.413009 s 0.243% ✅
firedancer mem usage with mainnet.toml 992.14 GiB 992.14 GiB 0.000% ✅

@github-actions
Copy link

github-actions bot commented Nov 11, 2025

Performance Measurements ⏳

Suite Baseline New Change
backtest mainnet-368528500-perf per slot 0.076617 s 0.076218 s -0.521% ✅
backtest mainnet-368528500-perf snapshot load 2.622 s 2.655 s 1.259% ✅
backtest mainnet-368528500-perf total elapsed 76.617484 s 76.21783 s -0.522% ✅
firedancer mem usage with mainnet.toml 992.14 GiB 992.14 GiB 0.000% ✅

@github-actions
Copy link

github-actions bot commented Nov 11, 2025

Performance Measurements ⏳

Suite Baseline New Change
backtest mainnet-368528500-perf per slot 0.059957 s 0.051959 s -13.340% ✅
backtest mainnet-368528500-perf snapshot load 1.836 s 1.418 s -22.767% ✅
backtest mainnet-368528500-perf total elapsed 59.956771 s 51.95872 s -13.340% ✅
firedancer mem usage with mainnet.toml 992.14 GiB 992.14 GiB 0.000% ✅

@github-actions
Copy link

github-actions bot commented Nov 13, 2025

Performance Measurements ⏳

Suite Baseline New Change
backtest mainnet-368528500-perf per slot 0.063836 s 0.054086 s -15.274% ✅
backtest mainnet-368528500-perf snapshot load 2.632 s 1.863 s -29.217% ✅
backtest mainnet-368528500-perf total elapsed 63.835787 s 54.085733 s -15.274% ✅
firedancer mem usage with mainnet.toml 996.14 GiB 996.14 GiB 0.000% ✅

@github-actions
Copy link

github-actions bot commented Nov 13, 2025

Performance Measurements ⏳

Suite Baseline New Change
backtest mainnet-368528500-perf per slot 0.075634 s 0.075782 s 0.196% ✅
backtest mainnet-368528500-perf snapshot load 3.241 s 3.193 s -1.481% ✅
backtest mainnet-368528500-perf total elapsed 75.633784 s 75.782073 s 0.196% ✅
firedancer mem usage with mainnet.toml 996.14 GiB 996.14 GiB 0.000% ✅

@github-actions
Copy link

github-actions bot commented Nov 13, 2025

Performance Measurements ⏳

Suite Baseline New Change
backtest mainnet-368528500-perf per slot 0.060692 s 0.052136 s -14.097% ✅
backtest mainnet-368528500-perf snapshot load 2.569 s 1.654 s -35.617% ✅
backtest mainnet-368528500-perf total elapsed 60.691949 s 52.13629 s -14.097% ✅
firedancer mem usage with mainnet.toml 996.14 GiB 996.14 GiB 0.000% ✅

@github-actions
Copy link

github-actions bot commented Nov 13, 2025

Performance Measurements ⏳

Suite Baseline New Change
backtest mainnet-368528500-perf per slot 0.075533 s 0.075517 s -0.021% ✅
backtest mainnet-368528500-perf snapshot load 3.249 s 3.155 s -2.893% ✅
backtest mainnet-368528500-perf total elapsed 75.533026 s 75.516539 s -0.022% ✅
firedancer mem usage with mainnet.toml 996.14 GiB 996.14 GiB 0.000% ✅

@cmoyes-jump cmoyes-jump force-pushed the cmoyes/elfmismatch branch 2 times, most recently from f4d66b3 to 2544982 Compare November 13, 2025 21:52
topointon-jump
topointon-jump previously approved these changes Nov 13, 2025
View reviewed changes
Copy link
Contributor

@topointon-jump topointon-jump left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🔥

mjain-jump
mjain-jump reviewed Nov 14, 2025
View reviewed changes
@github-actions
Copy link

github-actions bot commented Nov 14, 2025

Performance Measurements ⏳

Suite Baseline New Change
backtest mainnet-368528500-perf per slot 0.073914 s 0.074077 s 0.221% ✅
backtest mainnet-368528500-perf snapshot load 3.231 s 3.157 s -2.290% ✅
backtest mainnet-368528500-perf total elapsed 73.91395 s 74.076641 s 0.220% ✅
firedancer mem usage with mainnet.toml 996.11 GiB 996.11 GiB 0.000% ✅

@github-actions
Copy link

github-actions bot commented Nov 14, 2025

Performance Measurements ⏳

Suite Baseline New Change
backtest mainnet-368528500-perf per slot 0.076997 s 0.076771 s -0.294% ✅
backtest mainnet-368528500-perf snapshot load 3.092 s 3.026 s -2.135% ✅
backtest mainnet-368528500-perf total elapsed 76.99673 s 76.770991 s -0.293% ✅
firedancer mem usage with mainnet.toml 996.11 GiB 996.11 GiB 0.000% ✅

@github-actions
Copy link

github-actions bot commented Nov 14, 2025

Performance Measurements ⏳

Suite Baseline New Change
backtest mainnet-368528500-perf per slot 0.053364 s 0.053111 s -0.474% ✅
backtest mainnet-368528500-perf snapshot load 2.553 s 1.796 s -29.651% ✅
backtest mainnet-368528500-perf total elapsed 53.363805 s 53.110647 s -0.474% ✅
firedancer mem usage with mainnet.toml 996.11 GiB 996.11 GiB 0.000% ✅

@github-actions
Copy link

github-actions bot commented Nov 14, 2025

Performance Measurements ⏳

Suite Baseline New Change
backtest mainnet-368528500-perf per slot 0.053144 s 0.053684 s 1.016% ✅
backtest mainnet-368528500-perf snapshot load 2.619 s 1.822 s -30.431% ✅
backtest mainnet-368528500-perf total elapsed 53.143988 s 53.684106 s 1.016% ✅
firedancer mem usage with mainnet.toml 996.11 GiB 996.11 GiB 0.000% ✅

@cmoyes-jump
Update ELF laoder version mapping
612a523 
Mismatch log fixes

Syscall macros for temporarily setting errors

Error code aliasing

Move syscall override

log collector

Macro cleanup

Patch vote mismatch

Create non-nuil, but empty treap / pools

flamenco: unify instr error codes 20 and 33 properly (#7205)

Validate accounts in zk-elgamal-proof process_close_proof_context

Surgical edits to verify proof for v3.1

syscalls: revert special casing (#7209)

3.1 rekeys (#7216)

Bump test vectors

Update SHA

Use mainline SHA

Remove spurious loop

Add old

update features in ledger backtests

Remove spurious loop

Add old

update features in ledger backtests
@github-actions
Copy link

github-actions bot commented Nov 14, 2025

Performance Measurements ⏳

Suite Baseline New Change
backtest mainnet-368528500-perf per slot 0.053113 s 0.053168 s 0.104% ✅
backtest mainnet-368528500-perf snapshot load 2.596 s 1.777 s -31.549% ✅
backtest mainnet-368528500-perf total elapsed 53.113125 s 53.16842 s 0.104% ✅
firedancer mem usage with mainnet.toml 996.11 GiB 996.11 GiB 0.000% ✅

@cmoyes-jump cmoyes-jump merged commit 6587c6a into main Nov 14, 2025
13 checks passed
@cmoyes-jump cmoyes-jump deleted the cmoyes/elfmismatch branch November 14, 2025 17:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@mjain-jump mjain-jump mjain-jump approved these changes

@topointon-jump topointon-jump topointon-jump left review comments

Assignees

@cmoyes-jump cmoyes-jump

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@cmoyes-jump @mjain-jump @topointon-jump