gossip: fix DoS with malformed UDP header value/size #7146
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Performance Measurements ⏳
|
jherrera-jump
requested changes
Nov 10, 2025
Contributor
jherrera-jump
left a comment
jherrera-jump
left a comment
There was a problem hiding this comment.
Could you also update
firedancer/src/disco/gui/fd_gui_peers.c
Line 217 in 548c705
mmcgee-jump
reviewed
Nov 10, 2025
src/discof/gossip/fd_gossvf_tile.c
Outdated
| fd_ip4_hdr_t * ip4_hdr; | ||
| fd_udp_hdr_t * udp_hdr; | ||
| FD_TEST( fd_ip4_udp_hdr_strip( ctx->payload, sz, &payload, &payload_sz, NULL, &ip4_hdr, &udp_hdr ) ); | ||
| if( FD_UNLIKELY(!fd_ip4_udp_hdr_strip( ctx->payload, sz, &payload, &payload_sz, NULL, &ip4_hdr, &udp_hdr )) ) return FD_METRICS_ENUM_GOSSVF_MESSAGE_OUTCOME_V_DROPPED_MALFORMED_PACKET_IDX; |
Contributor
There was a problem hiding this comment.
How is this reachable? The net tile will not pass the packet to gossvf if the header is not valid
Contributor
Author
There was a problem hiding this comment.
The XDP tile does not check all this, see the PoC in https://github.com/firedancer-io/auditor-internal/issues/334
credits for finding this to Immunefi user `@bpop23293`
two-heart
force-pushed
the
two-heart/fix-gossvf-udp
branch
from
a88c593 to
75b8d46
Compare
Performance Measurements ⏳
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
credits for finding this to Immunefi user
@bpop23293