-
Couldn't load subscription status.
- Fork 65
feat: sql audit store #720
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
…features/sql-audit-store
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Good work!, some minor comments
...lamingock-auditstore-sql/src/main/java/io/flamingock/community/sql/driver/SqlAuditStore.java
Show resolved
Hide resolved
...lamingock-auditstore-sql/src/main/java/io/flamingock/community/sql/driver/SqlAuditStore.java
Outdated
Show resolved
Hide resolved
...ingock-auditstore-sql/src/main/java/io/flamingock/community/sql/internal/SqlLockService.java
Outdated
Show resolved
Hide resolved
...ingock-auditstore-sql/src/main/java/io/flamingock/community/sql/internal/SqlLockService.java
Outdated
Show resolved
Hide resolved
...ingock-auditstore-sql/src/main/java/io/flamingock/community/sql/internal/SqlLockService.java
Outdated
Show resolved
Hide resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please, before adding the line to initialise the lockService, investigate why the tests didn't spot this
...lamingock-auditstore-sql/src/main/java/io/flamingock/community/sql/driver/SqlAuditStore.java
Show resolved
Hide resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Some additional comments
feat: sql audit store