Optimize RadiusResultSet::copy #475
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Perform std::partial_sort instead of full std::sort in RadiusResultSet if not all items need to be returned.
|
As discussed elsewhere:
|
Branched between sort and partial_sort; used the more explicit dist_index_.size() instead of size().
Fix formatting.
|
Thomas, I've addressed your feedback. Also merged lines in the partial_sort invocation to match the current style in this file. |
|
Thanks! Looks like a very nice improvement! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Perform std::partial_sort instead of full std::sort in RadiusResultSet if not all items need to be returned.