Skip to content

Conversation

@janden
Copy link
Collaborator

@janden janden commented Feb 15, 2022

Clone of #125. See if creating the PR from the origin repository allows Jenkins to trust the updated Jenkinsfile.

@janden janden mentioned this pull request Feb 15, 2022
@ahbarnett ahbarnett marked this pull request as ready for review February 15, 2022 16:29
@ahbarnett ahbarnett self-assigned this Feb 15, 2022
Copy link
Collaborator

@ahbarnett ahbarnett left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

let's see how this goes. I'm not the Jenkins expert. Let's keep in mind that make check takes a few minutes to run, and does not have official pass/fail detection; it's a matter of if the tests compile and run (no math check is actually done).

@ahbarnett ahbarnett merged commit 3ae9871 into master Feb 15, 2022
@ahbarnett ahbarnett deleted the jenkins_make_check branch February 15, 2022 16:34
@janden
Copy link
Collaborator Author

janden commented Feb 15, 2022

it's a matter of if the tests compile and run (no math check is actually done).

May be something to add. I'll make an issue.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants