[Bugfix] Incorrect derivatives (CPU and GPU) and incorrect computations (GPU) #159
+356
−37
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
From the other open pull request it is clear the developers are aware, but recall that you need to top pin jax <= 0.6.2 . |
|
Hi please see #160 as I believe it resolves the issue, which stems from |
for more information, see https://pre-commit.ci
|
@TomHilder Glad you found it as well! They should buy us a smoothie or something. I am still getting some issues, I'll share if there's some direction to debug if you are working on this also |
unalmis
changed the title
for more information, see https://pre-commit.ci
for more information, see https://pre-commit.ci
unalmis
changed the title
for more information, see https://pre-commit.ci
|
@lgarrison Could you please approve the workflow to enable running the remaining tests? |
@dfm Are you available to approve the workflow? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Please approve so that I may squash merge.
main, most of the tests check whether thenufftcan do function approximation on uniformly random noise with zero mean. The tests added here are more likely to catch some errors.modeordbug that yields incorrect derivatives