migration to jax ffi for > 0.8 #189
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
for more information, see https://pre-commit.ci
Author
|
CI passing (#175) |
dfm
requested changes
Nov 29, 2025
Collaborator
dfm
left a comment
dfm
left a comment
There was a problem hiding this comment.
Thanks - This looks great!! Some small comments inline.
for more information, see https://pre-commit.ci
for more information, see https://pre-commit.ci
for more information, see https://pre-commit.ci
for more information, see https://pre-commit.ci
Author
|
Thank you @dfm for your comments! I've addressed all of them. I ran into vmap issues on GPU when using skip_ffi_layout_processing=True. The fix was to use dimension-specific FFI bindings. Feel free to squash the commits 😅 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Migration to JAX ffi
This draft introduces an initial migration to the new JAX FFI. The goal is to help collaborators transition away from deprecated APIs and ensure compatibility with JAX ≥ 0.8.
The current version has been tested on both an A100 GPU environment and macOS with jaxlib=0.8.1, and all tests passed without depreciation warning or errors.
I am also using this implementation in one of my own projects without issues so far.