builder-manifest: run appstream compose with --no-partial-urls #576
Conversation
|
This requires at least appstreamcli>=0.16.3 in meson.build. I think it is fine, partials URLs when a baseurl is supplied doesn't make sense. The spec says icon/image should start with http(s)
I don't think this fixes that issue? |
|
This fixes a problem we would experience in the Flathub backend, and |
I think this is all that's needed to land this. |
I guess building on fedora 38 is a no go. |
|
Also it's a runtime dependency while this is a meson (build-time) check. |
hfiguiere
force-pushed
the
no-partial-urls
branch
from
ac66435 to
9f9aa46
Compare
|
done, but I don't think it will build in CI |
|
On CI: |
|
Ubuntu 23.10 has 0.16.2... how annoying. |
Only when mirroring. This is to be compatible with existing flatpak deployment and appstream-glib See ximion/appstream#505 Should fix flatpak#573 Signed-off-by: Hubert Figuière <[email protected]>
hfiguiere
force-pushed
the
no-partial-urls
branch
from
9f9aa46 to
c9f7ad0
Compare
|
Ubuntu folks clarified that it's unlikely they'll ever update the appstream package, so either the Ubuntu workflows are dropped, or updated to a non-LTS version |
|
I'll reset the checks in meson and check at runtime in some way. Using CLI as an API... |
|
And this, in turn, explodes with this: so I'm dropping it after all |
barthalion
force-pushed
the
no-partial-urls
branch
from
3a91836 to
c9f7ad0
Compare
|
The approach here would be to degrade if the version of appstream is too low. But the check is a bit too hackish. Checking in meson.build is kind of irrelevant since it's build time. |
appstream-glib always composed with full urls. The URL policy got unintentionallly switched to partial urls during libappstream port in 1.3.x. Such a break in behaviour makes sense for unstable releases but we cannot revert back to full urls in a stable release. Using full URLs is desired for Flathub. So add a cli arg to control the behaviour and default to partial url. This may be flipped later in the next unstable release to default to full urls again. This is an alternative to #576
github-project-automation
bot
moved this from In Review
to Done
in @hfiguiere's xdg-portal
Only when mirroring. This is to be compatible with existing flatpak deployment and appstream-glib
See ximion/appstream#505
Should fix #573
This can be tested on flathub with flathub/org.flatpak.Builder#196