Enable authenticated downloads via netrc file #646
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sometimes source archives are only accessible to logged-in users, for example as described in issue flatpak#456. However, authentication currently is not supported by flatpak-builder aside from hard-coding credentials in the manifest file. Since flatpak-builder uses libcurl to download sources we can make use of cURL's support for netrc files to provide credentials out-of-band. That way the manifest file can be shared with others without leaking credentials. See the cURL documentation [0] for details about where cURL is looking for the .netrc file and the expected format of that file. [0] https://curl.se/libcurl/c/CURLOPT_NETRC.html
|
Seems fine to me. |
|
Seems to work. imo this should solve #456, using username@pass in the manifest should not be allowed. |
2 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Sometimes source archives are only accessible to logged-in users, for example as described in issue #456. However, authentication currently is not supported by flatpak-builder aside from hard-coding credentials in the manifest file.
Since flatpak-builder uses libcurl to download sources we can make use of cURL's support for netrc files to provide credentials out-of-band. While that does not directly solve #456 it offers an in my opinion superior alternative: Instead of hard-coding username and password in the manifest file the reporter of #456 can now create the file
~/.netrcwith the following content:This allows storing the manifest file in version control without exposing the credentials to all other developers.