Skip to content

Conversation

josxha
Copy link
Contributor

@josxha josxha commented Sep 19, 2025

Overview

  • update ci action versions (incorparates the changes by dependabot)
  • add lower flutter sdk bound to ci
  • pub upgrade / use stable http 1.5.0
  • fix windows ci, install innosetup manually
  • ignore deprecations (removal would break older flutter sdk versions)

Replaces

josxha and others added 7 commits September 19, 2025 09:53
Bumps [actions/github-script](https://github.com/actions/github-script) from 7 to 8.
- [Release notes](https://github.com/actions/github-script/releases)
- [Commits](actions/github-script@v7...v8)

---
updated-dependencies:
- dependency-name: actions/github-script
  dependency-version: '8'
  dependency-type: direct:production
  update-type: version-update:semver-major
...

Signed-off-by: dependabot[bot] <[email protected]>
Bumps [actions/stale](https://github.com/actions/stale) from 9 to 10.
- [Release notes](https://github.com/actions/stale/releases)
- [Changelog](https://github.com/actions/stale/blob/main/CHANGELOG.md)
- [Commits](actions/stale@v9...v10)

---
updated-dependencies:
- dependency-name: actions/stale
  dependency-version: '10'
  dependency-type: direct:production
  update-type: version-update:semver-major
...

Signed-off-by: dependabot[bot] <[email protected]>
Bumps [actions/setup-java](https://github.com/actions/setup-java) from 4 to 5.
- [Release notes](https://github.com/actions/setup-java/releases)
- [Commits](actions/setup-java@v4...v5)

---
updated-dependencies:
- dependency-name: actions/setup-java
  dependency-version: '5'
  dependency-type: direct:production
  update-type: version-update:semver-major
...

Signed-off-by: dependabot[bot] <[email protected]>
Bumps [actions/checkout](https://github.com/actions/checkout) from 4 to 5.
- [Release notes](https://github.com/actions/checkout/releases)
- [Changelog](https://github.com/actions/checkout/blob/main/CHANGELOG.md)
- [Commits](actions/checkout@v4...v5)

---
updated-dependencies:
- dependency-name: actions/checkout
  dependency-version: '5'
  dependency-type: direct:production
  update-type: version-update:semver-major
...

Signed-off-by: dependabot[bot] <[email protected]>
@josxha josxha self-assigned this Sep 19, 2025
@josxha josxha marked this pull request as draft September 19, 2025 08:06
@josxha josxha removed their assignment Sep 19, 2025
@josxha josxha force-pushed the update branch 2 times, most recently from 18c7b0d to fbf8a24 Compare September 19, 2025 09:07
@josxha josxha requested a review from Copilot September 19, 2025 09:15
Copy link

@Copilot Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR updates the project's CI infrastructure and dependencies to resolve deprecation warnings while maintaining backward compatibility. The changes focus on upgrading GitHub Actions, stabilizing dependencies, and ensuring CI works across multiple Flutter SDK versions.

  • Updates GitHub Actions to their latest versions (checkout@v5, setup-java@v5, etc.)
  • Upgrades http package from beta to stable version 1.5.0
  • Adds lower bound Flutter SDK testing (3.27.0) to CI matrix alongside latest stable

Reviewed Changes

Copilot reviewed 10 out of 11 changed files in this pull request and generated 1 comment.

Show a summary per file
File Description
pubspec.yaml Updates http dependency from beta to stable 1.5.0
lib/src/map/camera/camera.dart Adds deprecation ignore comments for Matrix4 translate calls
lib/src/layer/tile_layer/tile_provider/network/image_provider/image_provider.dart Adds ignore comment for unnecessary meta import
lib/src/layer/tile_layer/tile_provider/network/image_provider/consolidate_response.dart Adds ignore comment for unnecessary meta import
lib/src/layer/tile_layer/tile_provider/network/caching/built_in/impl/native/native.dart Adds ignore comments for unnecessary imports
example/macos/Flutter/GeneratedPluginRegistrant.swift Auto-generated plugin registration for path_provider
.github/workflows/master.yml Updates action versions and adds Inno Setup installation for Windows builds
.github/workflows/issue-comment.yml Updates github-script action from v7 to v8
.github/workflows/daily.yml Updates stale action from v9 to v10
.github/workflows/branch.yml Updates action versions and adds matrix strategy for multi-SDK testing
Comments suppressed due to low confidence (2)

.github/workflows/branch.yml:92

  • The Flutter version should be set based on the matrix SDK value. When matrix.sdk is '3.27.0', it should use that specific version instead of 'stable'. Consider using flutter-version: ${{ matrix.sdk || 'stable' }}.
          cache: true

.github/workflows/branch.yml:155

  • The Flutter version should be set based on the matrix SDK value. Use flutter-version: ${{ matrix.sdk || 'stable' }} instead of hardcoding 'stable' channel to properly test against the specified SDK versions.
          channel: "stable"
          cache: true

Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.

@josxha josxha requested a review from Copilot September 19, 2025 09:31
Copy link

@Copilot Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

Copilot reviewed 11 out of 12 changed files in this pull request and generated 2 comments.


Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.

@josxha josxha marked this pull request as ready for review September 19, 2025 09:32
@josxha josxha requested a review from a team September 19, 2025 09:34
@JaffaKetchup JaffaKetchup linked an issue Sep 19, 2025 that may be closed by this pull request
Copy link
Member

@JaffaKetchup JaffaKetchup left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍

@josxha josxha changed the title feat: resolve deprecations, bump action versions, add lower flutter sdk bound to ci chore: ignore deprecations, bump action versions, add lower flutter sdk bound to ci Sep 19, 2025
@josxha
Copy link
Contributor Author

josxha commented Sep 19, 2025

not sure of the title, if you want you can modify and merge😄 thanks for the review (:

@josxha josxha merged commit 2ab5c12 into fleaflet:master Sep 19, 2025
11 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

CI failing on existing code
2 participants