Skip to content

fix(): AxisymmetricBody profile curve ignoring requested units #1573

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
benflexcompute merged 1 commit into from
Nov 10, 2025
Merged

fix(): AxisymmetricBody profile curve ignoring requested units #1573

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 3 additions & 0 deletions flow360/component/simulation/framework/base_model.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -51,6 +51,9 @@ def _preprocess_nested_list(value, required_by, params, exclude, flow360_unit_sy
flow360_unit_system=flow360_unit_system,
)
)
elif need_conversion(item):
# Convert nested dimensioned values to base unit system
new_list.append(item.in_base(flow360_unit_system))
else:
# Return item unchanged if it doesn't need processing.
new_list.append(item)
Expand Down
20 changes: 20 additions & 0 deletions tests/simulation/translator/ref/volume_meshing/ref_param_to_json_inhouse.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -147,6 +147,26 @@
"spacingCircumferential": 0.2,
"spacingRadial": 0.4,
"enclosedObjects": []
},
{
"type": "Axisymmetric",
"name": "cone_mm_curve",
"axisOfRotation": [
0.7071067811865476,
0.0,
0.7071067811865476
],
"center": [0.0, 0.01, 0.0],
"profileCurve": [
[-1.0e-3, 0.0],
[-1.0e-3, 1.0e-3],
[1.0e-3, 2.0e-3],
[1.0e-3, 0.0]
],
"spacingAxial": 0.04,
"spacingCircumferential": 0.02,
"spacingRadial": 0.4,
"enclosedObjects": []
}
],
"structuredRegions": [
Expand Down
64 changes: 5 additions & 59 deletions tests/simulation/translator/ref/volume_meshing/ref_param_to_json_legacy.json
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,6 +1,6 @@
{
"refinementFactor": 1.45,
"farfield": {"type": "user-defined", "domainType": "half_body_negative_y"},
"farfield": {"type": "user-defined"},
"volume": {
"firstLayerThickness": 1.35e-06,
"growthRate": 1.04,
Expand All @@ -9,8 +9,7 @@
"faces": {
"boundary1": {
"firstLayerThickness": 0.5,
"type": "aniso",
"growthRate": 1.3
"type": "aniso"
},
"passive1": {"type": "projectAnisoSpacing"},
"passive2": {"type": "none"}
Expand All @@ -29,7 +28,7 @@
"size": [4.0, 5.0, 6.0],
"center": [0.0, 1.0, 2.0],
"axisOfRotation": [0.0, 0.0, 1.0],
"angleOfRotation": 45.0,
"angleOfRotation": 45.00000000000001,
"spacing": 0.075
}
],
Expand Down Expand Up @@ -61,8 +60,7 @@
"hub",
"blade1",
"blade2",
"blade3",
"slidingInterface-cone"
"blade3"
]
},
{
Expand All @@ -88,8 +86,7 @@
"spacingRadial": 0.2,
"spacingCircumferential": 0.2,
"enclosedObjects": [
"rotorDisk-enclosed",
"structuredBox-porousRegion"
"rotorDisk-enclosed"
]
},
{
Expand Down Expand Up @@ -120,57 +117,6 @@
"slidingInterface-2",
"slidingInterface-3"
]
},
{
"name": "cone",
"axisOfRotation": [
0.7071067811865476,
0.0,
0.7071067811865476
],
"center": [0.0, 0.0, 0.0],
"profileCurve": [
[-1.0, 0.0],
[-1.0, 1.0],
[1.0, 2.0],
[1.0, 0.0]
],
"spacingAxial": 0.4,
"spacingCircumferential": 0.2,
"spacingRadial": 0.4,
"enclosedObjects": []
}
],
"structuredRegions": [
{
"name": "porousRegion",
"type": "box",
"lengthAxis1": 1.0,
"lengthAxis2": 2.0,
"lengthNormal": 1.0,
"axis1": [
0.7071067811865476,
0.7071067811865476,
0.0
],
"axis2": [
-0.7071067811865476,
0.7071067811865476,
0.0
],
"center": [0.0, 1.0, 1.0],
"spacingAxis1": 0.075,
"spacingAxis2": 0.1,
"spacingNormal": 0.15
}
],
"zones": [
{
"name": "custom_volume-1",
"patches": [
"interface1",
"interface2"
]
}
]
}
Expand Down
Loading