[FXC-4006][FXC-4053][25.6] Add validation for transition model output fields and output frequency settings #1580
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
angranl-flex
changed the title
| + " 0 is at beginning of simulation.", | ||
| ) | ||
|
|
||
| @pd.field_validator("frequency", "frequency_offset") |
Collaborator
There was a problem hiding this comment.
Suggested change
| @pd.field_validator("frequency", "frequency_offset") | |
| @pd.field_validator("frequency", "frequency_offset", mode="after") |
|
|
||
| @pd.field_validator("frequency", "frequency_offset") | ||
| @classmethod | ||
| def disable_frequecy_settings_in_steady_simulation(cls, value, info: pd.ValidationInfo): |
Collaborator
There was a problem hiding this comment.
Suggested change
| def disable_frequecy_settings_in_steady_simulation(cls, value, info: pd.ValidationInfo): | |
| def disable_frequency_settings_in_steady_simulation(cls, value, info: pd.ValidationInfo): |
Collaborator
There was a problem hiding this comment.
Let's make this change to 25.7 instead and write updater for this.
|
|
||
| @pd.field_validator("frequency", "frequency_offset") | ||
| @classmethod | ||
| def disable_frequecy_settings_in_steady_simulation(cls, value, info: pd.ValidationInfo): |
Collaborator
There was a problem hiding this comment.
Let's make this change to 25.7 instead and write updater for this.
| return params | ||
|
|
||
|
|
||
| def _check_output_fields_valid_given_transition_model(params): |
Collaborator
There was a problem hiding this comment.
Same here. Please add updater.
| import os | ||
| import re | ||
|
|
||
| import pydantic as pd |
| ) | ||
|
|
||
|
|
||
| def test_output_frequecy_settings_in_steady_simulation(): |
Collaborator
There was a problem hiding this comment.
Suggested change
| def test_output_frequecy_settings_in_steady_simulation(): | |
| def test_output_frequency_settings_in_steady_simulation(): |
| ) | ||
|
|
||
| params_as_dict = params.model_dump(exclude_none=True, mode="json") | ||
| print("haha", params_as_dict) |
Contributor
Author
|
Closed since we will only fix 25.7 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.