fix(): Validate domain_type and check for deleted surfaces in half-body simulations #1615
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…lations - Added validation to ensure domain_type (half_body_positive_y/negative_y) is consistent with the model bounding box. - Updated Surface._will_be_deleted_by_mesher to identify surfaces that will be trimmed by the half-body domain. - Synchronized check_symmetric_boundary_existence with domain_type to skip existence check when domain type enforces symmetry. - Added tests for domain type validation and surface deletion logic.
benflexcompute
merged commit 5cd538b
into
release-candidate/25.7
34 of 45 checks passed
github-actions bot
pushed a commit
that referenced
this pull request
Nov 26, 2025
…mulations (#1615) - Added validation to ensure domain_type (half_body_positive_y/negative_y) is consistent with the model bounding box. - Updated Surface._will_be_deleted_by_mesher to identify surfaces that will be trimmed by the half-body domain. - Synchronized check_symmetric_boundary_existence with domain_type to skip existence check when domain type enforces symmetry. - Added tests for domain type validation and surface deletion logic.
benflexcompute
added a commit
that referenced
this pull request
Nov 26, 2025
…aces in half-body simulations (#1616) * Validate `domain_type` and check for deleted surfaces in half-body simulations (#1615) - Added validation to ensure domain_type (half_body_positive_y/negative_y) is consistent with the model bounding box. - Updated Surface._will_be_deleted_by_mesher to identify surfaces that will be trimmed by the half-body domain. - Synchronized check_symmetric_boundary_existence with domain_type to skip existence check when domain type enforces symmetry. - Added tests for domain type validation and surface deletion logic. * Resolved conflict --------- Co-authored-by: Ben <[email protected]> Co-authored-by: benflexcompute <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
…