fix(): mirror selector registry coverage mismatch #1682
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Collaborator
benflexcompute
commented
Dec 25, 2025
benflexcompute
commented
- Factor mirror-status registry registration into a shared helper to keep dict-based and params-based registry builders consistent.
- Add regression test ensuring get_entity_info_and_registry_from_dict() and get_registry_from_params() expose the same mirror entities.
- Extend service test to assert validate_model() returns no schema errors for mirror-status params while preserving selector expansion behavior.
…keep dict-based and params-based registry builders consistent. - Add regression test ensuring get_entity_info_and_registry_from_dict() and get_registry_from_params() expose the same mirror entities. - Extend service test to assert validate_model() returns no schema errors for mirror-status params while preserving selector expansion behavior.
benflexcompute
deleted the
BenY/FixIncorrectExpressionMatchingDueToMissingMirror
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.