Skip to content

Various changes to address new 'bool' C23 type and preprocessor symbol clash #45

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
mxmanghi wants to merge 7 commits into
base: master
Choose a base branch
from
Open

Various changes to address new 'bool' C23 type and preprocessor symbol clash #45

mxmanghi wants to merge 7 commits into from

Conversation

@mxmanghi
Copy link
Contributor

@mxmanghi mxmanghi commented Sep 8, 2025 •
edited
Loading

various changes to address minor problems

  • Rename configure.in as configure.ac as recommended by autotools
  • Rename variable 'bool' into 'boolean (generic/yajltcl.c) since recent C32 compilers have introduced the type 'bool'
  • Explicit definition of MODULE_SCOPE avoids preprocessor symbol clashing when compiling with Tcl9
  • Undo INCLUDES symbol change that added the parent directory into the include directories list
  • changing CONST definitions into regular C 'const' as prescribed by the Tcl9 transition guidelines. It's not hurting the build against Tcl8 but I'm not sure if it can have side effects

I opened this PR months ago but didn't get any reaction. Maybe Chris Roberts (@NasaGeek) may help?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

1 participant

@mxmanghi