Skip to content

Conversation

@celdrake
Copy link
Collaborator

@celdrake celdrake commented Dec 2, 2025

Following changes in flightctl/flightctl#2108

Summary by CodeRabbit

  • Chores

    • Updated GitHub Actions checkout action to v6 across all CI/CD workflows
    • Upgraded Go toolchain version to 1.25.3 in build environments
  • Documentation

    • Updated minimum Go version requirement to 1.25 in project prerequisites

✏️ Tip: You can customize this high-level summary in your review settings.

@coderabbitai
Copy link

coderabbitai bot commented Dec 2, 2025

Walkthrough

Updates Go version from 1.24 to 1.25 across project build configurations and documentation. Upgrades GitHub Actions checkout action from v4 to v6 in all CI/CD workflows. No functional logic changes or feature additions.

Changes

Cohort / File(s) Change Summary
CI/CD Workflow Updates
.github/workflows/ci.yaml, .github/workflows/push-to-main.yaml, .github/workflows/release.yaml
Upgraded all actions/checkout steps from v4 to v6 across three workflows. No changes to configuration parameters or control flow.
Build Configuration
Containerfile, Containerfile.ocp
Updated proxy-build stage base image Go toolset version from 1.24.6-1762373805 to 1.25.3-1763633888.
Project Configuration
README.md, proxy/go.mod
Updated minimum Go version requirement in documentation from 1.24 to 1.25. Updated proxy/go.mod Go language and toolchain versions from 1.24.0/1.24.6 to 1.25.0/1.25.3.

Estimated code review effort

🎯 1 (Trivial) | ⏱️ ~5–10 minutes

  • All changes are straightforward version bumps with no functional logic modifications
  • Updates are homogeneous and repetitive in nature (same upgrade pattern applied consistently)
  • No new dependencies or breaking changes; verification is limited to confirming version compatibility

Pre-merge checks and finishing touches

✅ Passed checks (3 passed)
Check name Status Explanation
Description Check ✅ Passed Check skipped - CodeRabbit’s high-level summary is enabled.
Title check ✅ Passed The title 'Update go to v1.25' directly and clearly describes the main change: upgrading the Go version from 1.24 to 1.25 across all configuration files and dependencies.
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.
✨ Finishing touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Post copyable unit tests in a comment

📜 Recent review details

Configuration used: CodeRabbit UI

Review profile: CHILL

Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between aa9132e and 668a545.

📒 Files selected for processing (7)
  • .github/workflows/ci.yaml (5 hunks)
  • .github/workflows/push-to-main.yaml (3 hunks)
  • .github/workflows/release.yaml (1 hunks)
  • Containerfile (1 hunks)
  • Containerfile.ocp (1 hunks)
  • README.md (1 hunks)
  • proxy/go.mod (1 hunks)
🧰 Additional context used
🧠 Learnings (5)
📚 Learning: 2025-04-10T12:51:20.579Z
Learnt from: celdrake
Repo: flightctl/flightctl-ui PR: 266
File: libs/ui-components/src/components/Masthead/CommandLineToolsPage.tsx:95-95
Timestamp: 2025-04-10T12:51:20.579Z
Learning: The CLI tool name is always "flightctl", regardless of whether it's in the upstream (Flight Control) or downstream (Red Hat Edge Manager) version of the product.

Applied to files:

  • proxy/go.mod
📚 Learning: 2025-02-18T12:04:42.579Z
Learnt from: rawagner
Repo: flightctl/flightctl-ui PR: 209
File: apps/standalone/src/app/utils/apiCalls.ts:14-16
Timestamp: 2025-02-18T12:04:42.579Z
Learning: In the flightctl-ui codebase, error handling for API calls follows a React pattern where the caller component (e.g., AppToolbar.tsx) implements try-catch blocks and manages error states, rather than handling errors within the API utility functions themselves.

Applied to files:

  • proxy/go.mod
📚 Learning: 2025-02-18T12:04:42.579Z
Learnt from: rawagner
Repo: flightctl/flightctl-ui PR: 209
File: apps/standalone/src/app/utils/apiCalls.ts:14-16
Timestamp: 2025-02-18T12:04:42.579Z
Learning: In the flightctl-ui codebase, error handling for API calls (like logout) is implemented by the caller rather than within the API utility functions themselves.

Applied to files:

  • proxy/go.mod
📚 Learning: 2025-06-04T06:41:15.969Z
Learnt from: celdrake
Repo: flightctl/flightctl-ui PR: 308
File: libs/ui-components/src/components/Device/EditDeviceWizard/deviceSpecUtils.ts:204-204
Timestamp: 2025-06-04T06:41:15.969Z
Learning: In the flightctl-ui codebase, volume functionality is not yet implemented in the backend. TODO comments related to volume preservation (like in toAPIApplication function) are intentional placeholders for when backend volume support is added.

Applied to files:

  • proxy/go.mod
📚 Learning: 2025-01-07T10:11:14.375Z
Learnt from: rawagner
Repo: flightctl/flightctl-ui PR: 181
File: proxy/config/ocp.go:16-16
Timestamp: 2025-01-07T10:11:14.375Z
Learning: In the flightctl-ui repository, the `RBACNs` variable used in `proxy/config/ocp.go` is defined in `proxy/config/config.go` as a package-level variable that retrieves its value from the environment variable `K8S_RBAC_NS`.

Applied to files:

  • proxy/go.mod
⏰ Context from checks skipped due to timeout of 90000ms. You can increase the timeout in your CodeRabbit configuration to a maximum of 15 minutes (900000ms). (4)
  • GitHub Check: integration-tests
  • GitHub Check: Build
  • GitHub Check: Build ocp plugin
  • GitHub Check: Lint
🔇 Additional comments (7)
README.md (1)

7-7: Go prereq updated to 1.25

The documented minimum Go version now matches the proxy go.mod/toolchain and container base images; this keeps tooling consistent.

Please ensure all developer docs/automation outside this repo (e.g., main flightctl repo, internal runbooks) also reflect Go 1.25 to avoid mismatch.

.github/workflows/push-to-main.yaml (1)

21-21: Use of actions/checkout@v6 is consistent across push-to-main jobs

All checkout steps now use v6 with identical options; this keeps behavior aligned with CI/release workflows.

After merging, just confirm the push-to-main workflow still resolves the correct HEAD/tag for image tagging (CI run will validate that end‑to‑end).

Also applies to: 50-50, 90-90

proxy/go.mod (1)

3-5: Go language/toolchain bumped to 1.25.0 / toolchain go1.25.3

The Go version metadata now matches the new go-toolset base images and README; no module/dependency changes in this file.

Please ensure your build environments (local and CI) have Go 1.25.x available so toolchain go1.25.3 is honored and you don’t accidentally build with an older cached toolchain.

Containerfile.ocp (1)

15-15: Proxy build stage moved to go-toolset:1.25.3 for OCP image

Updating the proxy-build base image to Go 1.25.3 aligns with proxy/go.mod and the documented Go requirement.

Please confirm this specific tag (ubi9/go-toolset:1.25.3-1763633888) is available in your target registries and that the FIPS build (GOEXPERIMENT=strictfipsruntime) still passes in CI.

Containerfile (1)

15-15: Proxy build stage moved to go-toolset:1.25.3 for standalone image

The Go toolchain base image now matches the updated proxy go.mod and README minimum version.

Once CI runs, please check that the standalone image still builds cleanly with Go 1.25.3 and that any FIPS validation you perform downstream continues to pass.

.github/workflows/release.yaml (1)

18-18: Checkout action updated to v6

Line 18 updates actions/checkout to v6. The configuration and inputs remain unchanged from the previous version.

.github/workflows/ci.yaml (1)

16-16: CI jobs now uniformly use actions/checkout@v6

All CI jobs (preflight, lint, builds, integration tests) are on actions/checkout@v6; options are unchanged, so behavior should remain the same.

To verify that only v6 is used across workflows, run:

#!/bin/bash
rg -n "actions/checkout@v[0-9]+" .github/workflows || true

Also applies to: 38-38, 54-54, 68-68, 83-83


Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants