-
-
Notifications
You must be signed in to change notification settings - Fork 14
Select mesh when focusing camera on mesh #126
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Draft
Zishan-Rahman
wants to merge
19
commits into
flipcomputing:main
Choose a base branch
from
Zishan-Rahman:camera-mesh-focus
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Draft
Select mesh when focusing camera on mesh #126
Zishan-Rahman
wants to merge
19
commits into
flipcomputing:main
from
Zishan-Rahman:camera-mesh-focus
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
TODO: Get bounding box to show on specific mesh (properly get that to work)
…ead of calling entire toggleGizmo method
Fixes error where bounding box was not showing
…g mesh TODO: Figure out how to turn off bounding box when shown through showBoundingBox method
… showing its bounding box in focusCameraOnMesh
to also ensure bounding box gets hidden when no longer needed
…posite meshes in cases where camera focused on them
…hod in turnOffAllGizmos instead of manually resetting gizmos again with repeated code
|
@Zishan-Rahman I took a look at this and there are a few problems:
|
Fixes bug where primitive mesh visibility doesn't show upon mesh selected when focusing
…f and else block to just after if-statement
…as no attachedMesh but window has currentMesh
|
The first mesh needs to be deselected before focusing on the second mesh. Somehow we need to do that "unfocusing" from the code editor, rather than the canvas (where that's already possible). |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.