Skip to content

Conversation

djsauble
Copy link
Contributor

@djsauble djsauble commented Oct 1, 2025

No description provided.

@djsauble djsauble self-assigned this Oct 1, 2025
@github-actions github-actions bot added the documentation Improvements or additions to documentation label Oct 1, 2025
Copy link

github-actions bot commented Oct 1, 2025

@djsauble djsauble force-pushed the djsauble/ia_tweaks branch from 7c77d08 to f2f53d5 Compare October 1, 2025 19:43
Copy link

github-actions bot commented Oct 1, 2025

Copy link

github-actions bot commented Oct 1, 2025

Copy link

github-actions bot commented Oct 1, 2025

@djsauble djsauble force-pushed the djsauble/ia_tweaks branch from c7f27a7 to d9051b8 Compare October 1, 2025 20:15
@djsauble djsauble force-pushed the djsauble/ia_tweaks branch from d9051b8 to f44238a Compare October 1, 2025 20:16
Copy link

github-actions bot commented Oct 1, 2025

Copy link

github-actions bot commented Oct 1, 2025

@djsauble djsauble marked this pull request as ready for review October 1, 2025 20:22
@djsauble djsauble requested review from rossturk and zmitchell October 1, 2025 20:22
Copy link
Member

@zmitchell zmitchell left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Two things:

  • You'll need to add redirects to mkdocs.yml (at the very bottom) so we don't break existing links to the documentation.
  • (Personal preference) I prefer the URL slug for man pages to be /man/flox-* so it looks like the command you'd type in your terminal. You can do that by just renaming the directory, but you can keep the Manual sidebar name.

@djsauble djsauble force-pushed the djsauble/ia_tweaks branch from ab8ad4a to 1bb4c9b Compare October 1, 2025 21:16
@djsauble djsauble force-pushed the djsauble/ia_tweaks branch from 1bb4c9b to b3d4817 Compare October 1, 2025 21:18
@djsauble djsauble requested a review from zmitchell October 1, 2025 21:36
@djsauble
Copy link
Contributor Author

djsauble commented Oct 1, 2025

The link checker is getting rate-limited by gnu.org, hence the failure. Otherwise I think this is ready to go.

check_links.sh Outdated
-nv \
--remap "https://flox.dev/docs file://$PWD/site" \
--exclude "bash/manual/html_node" \
--exclude "bash/man/html_node" \
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is this a search and replace error?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yeah. Fixed.

redirect_maps:
'concepts/manifest.md': 'concepts/environments.md#manifesttoml'
'install-flox.md': 'install-flox/install.md'
'reference/command-reference/flox-activate.md': 'man/flox-activate.md'
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Did you check whether there was a glob syntax you could use instead of listing these individually?

Copy link
Contributor Author

@djsauble djsauble Oct 1, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Doesn't seem to be. The redirects plugin iterates through redirect_maps and uses mkdocs.utils.is_markdown_file to check whether each entry ends in .md.

Copy link

github-actions bot commented Oct 1, 2025

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

documentation Improvements or additions to documentation

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants