-
Notifications
You must be signed in to change notification settings - Fork 1.8k
cmake: backport #10778 and #10786 to 4.0. #10795
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
…in if. Signed-off-by: Phillip Whelan <[email protected]>
… disabled. Signed-off-by: Phillip Adair Stewart Whelan <[email protected]>
Caution Review failedFailed to post review comments. WalkthroughAdds new Prometheus textfile input; expands node/windows exporter metrics; introduces Windows TLS CertStore support; updates Azure Kusto auth (adds workload identity) and Elasticsearch API key; improves OTLP handling; adds output latency metrics; fixes JSON/CMetrics bugs; adds proxy-env ignore; multiple version bumps; Docker/CI updates; extensive Windows/Dockerfile changes; broad tests added. Changes
Sequence Diagram(s)sequenceDiagram
autonumber
participant User
participant FB as Fluent Bit
participant PT as in_prometheus_textfile
participant FS as Filesystem
participant CM as cmetrics Decoder
User->>FB: Starts pipeline
FB->>PT: cb_init (paths, scrape_interval)
loop Every scrape_interval
PT->>FS: Expand globs, read files
alt file readable
PT->>CM: decode(prometheus_text)
alt decode ok
CM-->>PT: cmt object
PT-->>FB: flb_input_metrics_append(cmt)
else decode error
PT-->>PT: log error
end
else unreadable/empty
PT-->>PT: log/debug
end
end
sequenceDiagram
autonumber
participant Out as out_azure_kusto
participant OAuth as OAuth2 helper
participant MSI as Azure MSI
participant WI as Workload Identity
Out->>Out: get_azure_kusto_token()
alt token expired
opt auth_type == workload_identity
Out->>WI: read federated token file
WI-->>Out: exchange for access token
end
opt auth_type == managed_identity (system/user)
Out->>MSI: request token (system or user-assigned)
MSI-->>Out: token
end
opt auth_type == service_principal
Out->>OAuth: client_credentials grant
OAuth-->>Out: token
end
else valid token
Out-->>Out: reuse
end
Estimated code review effort🎯 5 (Critical) | ⏱️ ~120+ minutes Possibly related PRs
Suggested labels
Suggested reviewers
Poem
Tip 🔌 Remote MCP (Model Context Protocol) integration is now available!Pro plan users can now connect to remote MCP servers from the Integrations page. Connect with popular remote MCPs such as Notion and Linear to add more context to your reviews and chats. ✨ Finishing Touches
🧪 Generate unit tests
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. 🪧 TipsChatThere are 3 ways to chat with CodeRabbit:
SupportNeed help? Create a ticket on our support page for assistance with any issues or questions. CodeRabbit Commands (Invoked using PR/Issue comments)Type Other keywords and placeholders
CodeRabbit Configuration File (
|
Summary
Allow disabling simdutf support.
Description
Backport of the patches #10778 and #10786 to make the use of simdutf optional.
Fluent Bit is licensed under Apache 2.0, by submitting this pull request I understand that this code will be released under the terms of that license.
Summary by CodeRabbit
New Features
Improvements
Bug Fixes
Chores