Skip to content

Conversation

@joshuabaird
Copy link
Collaborator

@joshuabaird joshuabaird commented Nov 11, 2025

Fixes #1670.

This PR replaces the usage of initContainers for configuring the container runtime with a more native and modern approach using ConfigMap and Volume.

In summary, this PR:

  • Removes the dependency on an outdated and unmaintained docker image
  • Uses a simpler more native approach using ConfigMaps and Volumes
  • Removes usage of a Docker socket mount which was required for the initContainers
  • Removes capability of automatic detection of logs for the docker runtime (used to happen via initContainer) but allows users to manually set this (see next bullet). Kubernetes has not used the docker runtime since v1.24 so this seems like a sensible option to simplify this code
  • Allows users to override default values for crio, containerd and docker using Helm values (eg, operator.logPath.docker

Signed-off-by: Josh Baird <[email protected]>
Signed-off-by: Josh Baird <[email protected]>
Signed-off-by: Josh Baird <[email protected]>
Signed-off-by: Josh Baird <[email protected]>
@joshuabaird joshuabaird marked this pull request as ready for review November 11, 2025 20:15
Signed-off-by: Josh Baird <[email protected]>
@joshuabaird
Copy link
Collaborator Author

I'm now wondering if we should just deprecate containerRuntime all together since it's only used for configuring Fluentbit. Both containerd (most common) and crio use the same log path. Could we simplify this even further?

Thoughts, @cw-Guo @marcofranssen @seanorama?

@joshuabaird
Copy link
Collaborator Author

Closing this to re-factor in other PRs.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

bug: docker init container should not be required when using other container engines (not docker)

1 participant