-
Notifications
You must be signed in to change notification settings - Fork 1.1k
refactor function SyncScheduleInfoToCacheNodes and add unit tests for util dataset functions #5220
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
refactor function SyncScheduleInfoToCacheNodes and add unit tests for util dataset functions #5220
Conversation
Signed-off-by: TrafalgarZZZ <[email protected]>
Signed-off-by: TrafalgarZZZ <[email protected]>
Signed-off-by: TrafalgarZZZ <[email protected]>
Signed-off-by: TrafalgarZZZ <[email protected]>
Signed-off-by: TrafalgarZZZ <[email protected]>
Signed-off-by: TrafalgarZZZ <[email protected]>
|
/test fluid-e2e |
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #5220 +/- ##
==========================================
+ Coverage 55.15% 55.38% +0.22%
==========================================
Files 444 444
Lines 30529 30536 +7
==========================================
+ Hits 16838 16911 +73
+ Misses 12139 12055 -84
- Partials 1552 1570 +18 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
/lgtm
/approve
/test fluid-e2e |
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: cheyang The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
@TrafalgarZZZ: The following test failed, say
Full PR test history. Your PR dashboard. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here. |
Ⅰ. Describe what this PR does
Ⅱ. Does this pull request fix one issue?
fixes #XXXX
Ⅲ. List the added test cases (unit test/integration test) if any, please explain if no tests are needed.
Ⅳ. Describe how to verify it
Ⅴ. Special notes for reviews