Skip to content

Conversation

TrafalgarZZZ
Copy link
Member

Ⅰ. Describe what this PR does

Ⅱ. Does this pull request fix one issue?

fixes #XXXX

Ⅲ. List the added test cases (unit test/integration test) if any, please explain if no tests are needed.

Ⅳ. Describe how to verify it

Ⅴ. Special notes for reviews

@TrafalgarZZZ TrafalgarZZZ changed the title refactor SyncScheduleInfoToAdd unit tests for util dataset functions refactor function SyncScheduleInfoToCacheNodes and add unit tests for util dataset functions Sep 7, 2025
Copy link

sonarqubecloud bot commented Sep 7, 2025

@TrafalgarZZZ
Copy link
Member Author

/test fluid-e2e

Copy link

codecov bot commented Sep 7, 2025

Codecov Report

❌ Patch coverage is 63.07692% with 24 lines in your changes missing coverage. Please review.
✅ Project coverage is 55.38%. Comparing base (5b1b9cd) to head (d493f34).
⚠️ Report is 26 commits behind head on master.

Files with missing lines Patch % Lines
pkg/utils/dataset/lifecycle/node.go 63.07% 15 Missing and 9 partials ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##           master    #5220      +/-   ##
==========================================
+ Coverage   55.15%   55.38%   +0.22%     
==========================================
  Files         444      444              
  Lines       30529    30536       +7     
==========================================
+ Hits        16838    16911      +73     
+ Misses      12139    12055      -84     
- Partials     1552     1570      +18     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

Copy link
Collaborator

@cheyang cheyang left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm
/approve

@cheyang
Copy link
Collaborator

cheyang commented Sep 23, 2025

/test fluid-e2e

@cheyang cheyang merged commit 7afa811 into fluid-cloudnative:master Sep 23, 2025
16 of 17 checks passed
@fluid-e2e-bot fluid-e2e-bot bot added the lgtm label Sep 24, 2025
Copy link

fluid-e2e-bot bot commented Sep 24, 2025

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: cheyang

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

Copy link

fluid-e2e-bot bot commented Sep 24, 2025

@TrafalgarZZZ: The following test failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
fluid-e2e d493f34 link true /test fluid-e2e

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants