-
Notifications
You must be signed in to change notification settings - Fork 1.1k
Update build ci #5332
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: master
Are you sure you want to change the base?
Update build ci #5332
Conversation
Signed-off-by: cheyang <[email protected]>
Signed-off-by: cheyang <[email protected]>
|
Note Gemini is unable to generate a summary for this pull request due to the file types involved not being currently supported. |
|
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: The full list of commands accepted by this bot can be found here.
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pull Request Overview
This PR updates the CI build configuration to exclude the SA1019 check (which warns about deprecated API usage) from both staticcheck and golangci-lint tools, allowing the project to continue using deprecated APIs without triggering linter failures.
- Adds configuration to staticcheck-action to exclude multiple style checks (ST1000, ST1003, ST1020, ST1021, ST1022) and the SA1019 deprecation check
- Updates golangci-lint arguments to exclude SA1019 deprecation warnings
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
.github/workflows/project-check.yml
Outdated
| with: | ||
| checks: '["all", "-ST1000", "-ST1003", "-ST1020", "-ST1021", "-ST1022", "-SA1019"]' |
Copilot
AI
Nov 11, 2025
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The with parameter is incorrectly indented. It should be at the same indentation level as the uses statement on line 20 (indented with 8 spaces, not 4). Currently, it's indented at the steps level rather than at the action level.
The correct structure should be:
- uses: dominikh/staticcheck-action@024238d2898c874f26d723e7d0ff4308c35589a2 # v1
with:
checks: '["all", "-ST1000", "-ST1003", "-ST1020", "-ST1021", "-ST1022", "-SA1019"]'| with: | |
| checks: '["all", "-ST1000", "-ST1003", "-ST1020", "-ST1021", "-ST1022", "-SA1019"]' | |
| with: | |
| checks: '["all", "-ST1000", "-ST1003", "-ST1020", "-ST1021", "-ST1022", "-SA1019"]' |
Signed-off-by: cheyang <[email protected]>
Signed-off-by: cheyang <[email protected]>
|
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## master #5332 +/- ##
=======================================
Coverage 56.96% 56.96%
=======================================
Files 442 442
Lines 30529 30529
=======================================
Hits 17390 17390
Misses 11523 11523
Partials 1616 1616 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|



Ⅰ. Describe what this PR does
Ⅱ. Does this pull request fix one issue?
fixes #XXXX
Ⅲ. List the added test cases (unit test/integration test) if any, please explain if no tests are needed.
Ⅳ. Describe how to verify it
Ⅴ. Special notes for reviews