Skip to content

Conversation

@cheyang
Copy link
Collaborator

@cheyang cheyang commented Nov 11, 2025

Ⅰ. Describe what this PR does

Ⅱ. Does this pull request fix one issue?

fixes #XXXX

Ⅲ. List the added test cases (unit test/integration test) if any, please explain if no tests are needed.

Ⅳ. Describe how to verify it

Ⅴ. Special notes for reviews

@gemini-code-assist
Copy link
Contributor

Note

Gemini is unable to generate a summary for this pull request due to the file types involved not being currently supported.

@fluid-e2e-bot
Copy link

fluid-e2e-bot bot commented Nov 11, 2025

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by:
Once this PR has been reviewed and has the lgtm label, please ask for approval from cheyang by writing /assign @cheyang in a comment. For more information see:The Kubernetes Code Review Process.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR updates the CI build configuration to exclude the SA1019 check (which warns about deprecated API usage) from both staticcheck and golangci-lint tools, allowing the project to continue using deprecated APIs without triggering linter failures.

  • Adds configuration to staticcheck-action to exclude multiple style checks (ST1000, ST1003, ST1020, ST1021, ST1022) and the SA1019 deprecation check
  • Updates golangci-lint arguments to exclude SA1019 deprecation warnings

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

Comment on lines 21 to 22
with:
checks: '["all", "-ST1000", "-ST1003", "-ST1020", "-ST1021", "-ST1022", "-SA1019"]'
Copy link

Copilot AI Nov 11, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The with parameter is incorrectly indented. It should be at the same indentation level as the uses statement on line 20 (indented with 8 spaces, not 4). Currently, it's indented at the steps level rather than at the action level.

The correct structure should be:

    - uses: dominikh/staticcheck-action@024238d2898c874f26d723e7d0ff4308c35589a2 # v1
      with:
        checks: '["all", "-ST1000", "-ST1003", "-ST1020", "-ST1021", "-ST1022", "-SA1019"]'
Suggested change
with:
checks: '["all", "-ST1000", "-ST1003", "-ST1020", "-ST1021", "-ST1022", "-SA1019"]'
with:
checks: '["all", "-ST1000", "-ST1003", "-ST1020", "-ST1021", "-ST1022", "-SA1019"]'

Copilot uses AI. Check for mistakes.
@sonarqubecloud
Copy link

@codecov
Copy link

codecov bot commented Nov 11, 2025

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 56.96%. Comparing base (e075550) to head (813ca95).

Additional details and impacted files
@@           Coverage Diff           @@
##           master    #5332   +/-   ##
=======================================
  Coverage   56.96%   56.96%           
=======================================
  Files         442      442           
  Lines       30529    30529           
=======================================
  Hits        17390    17390           
  Misses      11523    11523           
  Partials     1616     1616           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant