-
Notifications
You must be signed in to change notification settings - Fork 5
GPII-2397: Clean up express-pouchdb log file after test runs.... #14
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
Widespread failure in the case the log file is not present: |
…ue logs, to avoid cleanup errors when running "persistence" tests and improve test stability in general. NOJIRA: Moved all configuration data to "in memory" (options) and removed the need for a config file.
|
I was able to reproduce this locally. The latest error was the result of a long-running goof where I created log files one directory too high, something like As part of investigating this, I discovered that all the required express-pouchdb options can now be configured directly using options passed when instantiating express-pouchdb. Previously, I had to save the options to a file and then pass options to load that file. I removed this workaround, which will reduce the amount of cleanup required as well. @amb26, this is ready for review again. |
|
The docs have been updated as well. I caught a few previously added options/features this go around. |
|
The commits so far in the pull request help to solve the "out of memory" issue I encountered when using gpii-pouchdb version 1.0.1 as a node dependency for my universal data loader pull request. In case someone is interested, here is the detail about the "out of memory" issue. |
|
The cleanup issues are again much improved and I think acceptable. The detritus left behind in /tmp in my system is now the following: The "tmp" files seem to be pure binary, perhaps created by a browser process. The directory remains empty after running the pure node-based process |
|
I have created GPII-2400 to track the remaining cleanup work in gpii-testem. |
See GPII-2397 for details.