Skip to content

Rename "observatoryUri" to "vmServiceUri" for test.startedProcess #8328

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Jul 14, 2025

Conversation

helomri
Copy link
Contributor

@helomri helomri commented Jul 12, 2025

This is due to the removal of Observatory support from Dart SDKs and Flutter which made the tests never unpause on recent versions of Flutter. This fixes #8233.

The URI pointing to Observatory is no longer given in test.startedProcess. Now, the URI to the VM Service for DevTools is present and can be used as a drop-in replacement to achieve the same functionality.


  • I’ve reviewed the contributor guide and applied the relevant portions to this PR.
Contribution guidelines:

@helomri helomri changed the title Rename "observatoryUri" to "vmServiceUri" for test.startedProcess (#8233) Rename "observatoryUri" to "vmServiceUri" for test.startedProcess Jul 12, 2025
@jwren jwren added the bug label Jul 14, 2025
@jwren jwren self-assigned this Jul 14, 2025
@jwren jwren added this to the M87 milestone Jul 14, 2025
@jwren
Copy link
Member

jwren commented Jul 14, 2025

Change looks good, the follow up here if you can would be to add a check for the old id if this fails. Also to add documentation to the issue.

…rviceUri ones.

- Adding documentation for the change in comments
@helomri
Copy link
Contributor Author

helomri commented Jul 14, 2025

@jwren Done. It's wise to keep both checks as 3.34 hasn't landed on stable yet and keeping backwards compatibility in this case is not that hard.

@jwren
Copy link
Member

jwren commented Jul 14, 2025

@helomri Thanks for updating, I'll land it when the presubmits pass.

@jwren jwren merged commit 90ca958 into flutter:master Jul 14, 2025
7 checks passed
@huycozy
Copy link
Member

huycozy commented Jul 15, 2025

Thank @helomri for the fix. Hope this will land on stable soon!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Flutter test stucks at "event":"test.startedProcess" when running it from Run button
3 participants