Skip to content

Conversation

Konoha-orz
Copy link

Fix video_player Windows platform loop seekTo issue on complete

  • Prevent unintended seekTo loop when video ends on Windows platform
  • Add platform-specific check to handle video completion correctly
  • Ensure smooth playback termination without redundant seek operations

Pre-Review Checklist

  • I read the [Contributor Guide] and followed the process outlined there for submitting PRs.
  • I read the [Tree Hygiene] page, which explains my responsibilities.
  • I read and followed the [relevant style guides] and ran [the auto-formatter].
  • I signed the [CLA].
  • The title of the PR starts with the name of the package surrounded by square brackets, e.g. [shared_preferences]
  • I [linked to at least one issue that this PR fixes] in the description above.
  • I updated pubspec.yaml with an appropriate new version according to the [pub versioning philosophy], or I have commented below to indicate which [version change exemption] this PR falls under[^1].
  • I updated CHANGELOG.md to add a description of the change, [following repository CHANGELOG style], or I have commented below to indicate which [CHANGELOG exemption] this PR falls under[^1].
  • I updated/added any relevant documentation (doc comments with ///).
  • I added new tests to check the change I am making, or I have commented below to indicate which [test exemption] this PR falls under[^1].
  • All existing and new tests are passing.

…video complete

video_player Windows platform loop seekTo issue on video complete

- Prevent unintended seekTo loop when video ends on Windows platform
- Add platform-specific check to handle video completion correctly
- Ensure smooth playback termination without redundant seek operations
@Konoha-orz Konoha-orz requested a review from tarrinneal as a code owner July 11, 2025 09:27
@flutter-dashboard
Copy link

It looks like this pull request may not have tests. Please make sure to add tests or get an explicit test exemption before merging.

If you are not sure if you need tests, consider this rule of thumb: the purpose of a test is to make sure someone doesn't accidentally revert the fix. Ask yourself, is there anything in your PR that you feel it is important we not accidentally revert back to how it was before your fix?

Reviewers: Read the Tree Hygiene page and make sure this patch meets those guidelines before LGTMing.If you believe this PR qualifies for a test exemption, contact "@test-exemption-reviewer" in the #hackers channel in Discord (don't just cc them here, they won't see it!). The test exemption team is a small volunteer group, so all reviewers should feel empowered to ask for tests, without delegating that responsibility entirely to the test exemption group.

@stuartmorgan-g
Copy link
Collaborator

Thanks for the contribution! You’ve checked boxes in the PR checklist above that are not reflected in this PR, so I’m assuming this is a work in progress and am marking it as a Draft. Please review the checklist, updating the PR as appropriate, and when the state of the PR as posted reflects the checklist please feel free to mark it as ready for review.

@stuartmorgan-g stuartmorgan-g marked this pull request as draft July 15, 2025 18:44
@stuartmorgan-g stuartmorgan-g removed the request for review from tarrinneal July 15, 2025 18:44
…video complete

video_player Windows platform loop seekTo issue on video complete

- Prevent unintended seekTo loop when video ends on Windows platform
- Add platform-specific check to handle video completion correctly
- Ensure smooth playback termination without redundant seek operations
@Konoha-orz Konoha-orz marked this pull request as ready for review July 16, 2025 05:47
@stuartmorgan-g
Copy link
Collaborator

  • I linked to at least one issue that this PR fixes in the description above.

This step has not been completed; we need a link to an issue with a clear, complete description of the issue, and steps to reproduce it.

(That is especially important here, because it is not at all clear what problem this is intended to solve given that we don't have a Windows implementation of this plugin.)

@stuartmorgan-g stuartmorgan-g marked this pull request as draft July 16, 2025 20:54
@stuartmorgan-g
Copy link
Collaborator

Since this is marked as a draft and hasn't been updated in over a month, I’m going to close it so that our PR queue reflects active PRs. Please don't hesitate to submit a new PR if you decide to revisit this. Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants