[In_app_purchase_storekit] Do not throw PigeonError when a transaction is pending / cancelled / unverified

[LongCatIsLooong]

Fixes flutter/flutter#169524

Pre-Review Checklist

• I read the Contributor Guide and followed the process outlined there for submitting PRs.
• I read the Tree Hygiene page, which explains my responsibilities.
• I read and followed the relevant style guides and ran the auto-formatter.
• I signed the CLA.
• The title of the PR starts with the name of the package surrounded by square brackets, e.g. [shared_preferences]
• I linked to at least one issue that this PR fixes in the description above.
• I updated pubspec.yaml with an appropriate new version according to the pub versioning philosophy, or I have commented below to indicate which version change exemption this PR falls under¹.
• I updated CHANGELOG.md to add a description of the change, following repository CHANGELOG style, or I have commented below to indicate which CHANGELOG exemption this PR falls under¹.
• I updated/added any relevant documentation (doc comments with ///).
• I added new tests to check the change I am making, or I have commented below to indicate which test exemption this PR falls under¹.
• All existing and new tests are passing.

If you need help, consider asking for advice on the #hackers-new channel on Discord.

Footnotes

1. Regular contributors who have demonstrated familiarity with the repository guidelines only need to comment if the PR is not auto-exempted by repo tooling. ↩ ↩² ↩³

[LongCatIsLooong]

According to the documentation unsafe seems to mean that the transaction is potentially unverified.

[stuartmorgan-g]

/gemini review

[stuartmorgan-g]

(Don't mind me, just testing out the newly enabled review bot on some of our open PRs to see how it does 🙂)

[gemini-code-assist]

Code Review

This pull request modifies the in_app_purchase_storekit plugin to handle pending, cancelled, and unverified transactions without throwing PigeonErrors. It introduces a new unverified case to the SK2ProductPurchaseResult enum and updates the StoreKit2 implementation to return the corresponding SK2ProductPurchaseResult in these scenarios.

[gemini-code-assist]

This function can be simplified for improved conciseness. The intermediate result variable is unnecessary; the Future from the _hostApi call can be returned directly using Dart's arrow syntax (=>).

  static Future<bool> isIntroductoryOfferEligible(String productId) =>
      _hostApi.isIntroductoryOfferEligible(productId);

[stuartmorgan-g]

We can eliminate the unnecessary result, but using => here would violate https://github.com/flutter/flutter/blob/master/docs/contributing/Style-guide-for-Flutter-repo.md#consider-using--for-short-functions-and-methods

[Piinks]

I think the style guide might be wrong now that we use dart format.

[hellohuanlin]

cc @LongCatIsLooong for the next step from triage meeting.

[okorohelijah]

cc @LouiseHsu from triage meeting

[LouiseHsu]

lgtm 👀

[axb-c]

Both the pending and userCancelled states should be communicated to the upper layer via either the buyXXX method or the purchaseStream.

[axb-c]

http://github.com/flutter/packages/blob/main/packages/in_app_purchase/in_app_purchase_storekit/lib/src/in_app_purchase_storekit_platform.dart#L181

      await SK2Product.purchase(
        purchaseParam.productDetails.id,
        options: options,
      );
      // The result is ignored(maybe pending/userCanceled)!
      return true;