Skip to content

[camera_android_camerax] Fix the rotation of captured videos and streamed images #9637

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 5 commits into from
Closed

[camera_android_camerax] Fix the rotation of captured videos and streamed images #9637

Changes from 1 commit
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
750c194
fixes
camsim99 Jul 16, 2025
1788b45
small refactor
camsim99 Jul 16, 2025
b7d54df
some debugging
camsim99 Jul 22, 2025
36f1ca4
why is it working?
camsim99 Jul 30, 2025
83e934e
Merge remote-tracking branch 'upstream/main' into camx_viddim
camsim99 Jul 30, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
27 changes: 7 additions & 20 deletions packages/camera/camera_android_camerax/lib/src/android_camera_camerax.dart
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -195,17 +195,6 @@ class AndroidCameraCameraX extends CameraPlatform {
@visibleForTesting
bool captureOrientationLocked = false;

/// Whether or not the default rotation for [UseCase]s needs to be set
/// manually because the capture orientation was previously locked.
///
/// Currently, CameraX provides no way to unset target rotations for
/// [UseCase]s, so once they are set and unset, this plugin must start setting
/// the default orientation manually.
///
/// See https://developer.android.com/reference/androidx/camera/core/ImageCapture#setTargetRotation(int)
/// for an example on how setting target rotations for [UseCase]s works.
bool shouldSetDefaultRotation = false;

/// Error code indicating that an exposure offset value failed to be set.
static const String setExposureOffsetFailedErrorCode =
'setExposureOffsetFailed';
Expand Down Expand Up @@ -390,17 +379,18 @@ class AndroidCameraCameraX extends CameraPlatform {
);

// Configure ImageCapture instance.
final int defaultDisplayRotation =
await deviceOrientationManager.getDefaultDisplayRotation();
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

medium

Consider extracting deviceOrientationManager.getDefaultDisplayRotation() to a local variable before calling proxy.newImageCapture. This avoids calling the platform multiple times, which could be inefficient.

final int defaultDisplayRotation = await deviceOrientationManager.getDefaultDisplayRotation();

imageCapture = proxy.newImageCapture(
resolutionSelector: presetResolutionSelector,
/* use CameraX default target rotation */ targetRotation:
await deviceOrientationManager.getDefaultDisplayRotation(),
targetRotation: defaultDisplayRotation,
);

// Configure ImageAnalysis instance.
// Defaults to YUV_420_888 image format.
imageAnalysis = proxy.newImageAnalysis(
resolutionSelector: presetResolutionSelector,
/* use CameraX default target rotation */ targetRotation: null,
targetRotation: defaultDisplayRotation,
);

// Configure VideoCapture and Recorder instances.
Expand Down Expand Up @@ -552,10 +542,7 @@ class AndroidCameraCameraX extends CameraPlatform {
int cameraId,
DeviceOrientation orientation,
) async {
// Flag that (1) default rotation for UseCases will need to be set manually
// if orientation is ever unlocked and (2) the capture orientation is locked
// and should not be changed until unlocked.
shouldSetDefaultRotation = true;
// Flag that the capture orientation is locked and should not be changed until unlocked.
captureOrientationLocked = true;

// Get target rotation based on locked orientation.
Expand Down Expand Up @@ -1104,7 +1091,7 @@ class AndroidCameraCameraX extends CameraPlatform {

// Set target rotation to default CameraX rotation only if capture
// orientation not locked.
if (!captureOrientationLocked && shouldSetDefaultRotation) {
if (!captureOrientationLocked) {
await videoCapture!.setTargetRotation(
await deviceOrientationManager.getDefaultDisplayRotation(),
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

medium

Instead of calling deviceOrientationManager.getDefaultDisplayRotation() directly within setTargetRotation, consider storing the value in a variable and reusing it. This avoids redundant calls to the platform, improving efficiency.

final rotation = await deviceOrientationManager.getDefaultDisplayRotation();
await videoCapture!.setTargetRotation(
  rotation,
);

);
Expand Down Expand Up @@ -1253,7 +1240,7 @@ class AndroidCameraCameraX extends CameraPlatform {

// Set target rotation to default CameraX rotation only if capture
// orientation not locked.
if (!captureOrientationLocked && shouldSetDefaultRotation) {
if (!captureOrientationLocked) {
await imageAnalysis!.setTargetRotation(
await deviceOrientationManager.getDefaultDisplayRotation(),
Comment on lines +1254 to 1256
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

medium

Instead of calling deviceOrientationManager.getDefaultDisplayRotation() directly within setTargetRotation, consider storing the value in a variable and reusing it. This avoids redundant calls to the platform, improving efficiency.

final rotation = await deviceOrientationManager.getDefaultDisplayRotation();
      await imageAnalysis!.setTargetRotation(
        rotation,
      );

);
Expand Down