[camera_avfoundation] Implementation swift migration - part 9 #9645
+161
−149
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
It looks like this pull request may not have tests. Please make sure to add tests or get an explicit test exemption before merging. If you are not sure if you need tests, consider this rule of thumb: the purpose of a test is to make sure someone doesn't accidentally revert the fix. Ask yourself, is there anything in your PR that you feel it is important we not accidentally revert back to how it was before your fix? Reviewers: Read the Tree Hygiene page and make sure this patch meets those guidelines before LGTMing.If you believe this PR qualifies for a test exemption, contact "@test-exemption-reviewer" in the #hackers channel in Discord (don't just cc them here, they won't see it!). The test exemption team is a small volunteer group, so all reviewers should feel empowered to ask for tests, without delegating that responsibility entirely to the test exemption group. |
![gemini-code-assist[bot]](https://avatars.githubusercontent.com/in/956858?s=60&v=4){kind=small}
There was a problem hiding this comment.
Code Review
This pull request migrates the video recording setup logic of the camera_avfoundation plugin from Objective-C to Swift. The implementation looks like a correct translation of the original logic. The review includes a high-priority fix for a potential crash due to an incorrect nullability annotation on an Objective-C method and its handling in Swift, and a medium-priority suggestion to adopt a more idiomatic Swift pattern for data conversion.
.../camera_avfoundation/ios/camera_avfoundation/Sources/camera_avfoundation/DefaultCamera.swift
Outdated
Show resolved
Hide resolved
...os/camera_avfoundation/Sources/camera_avfoundation_objc/include/camera_avfoundation/FLTCam.h
Outdated
Show resolved
Hide resolved
.../camera_avfoundation/ios/camera_avfoundation/Sources/camera_avfoundation/DefaultCamera.swift
Outdated
Show resolved
Hide resolved
hellohuanlin
approved these changes
Jul 22, 2025
| if flashMode == .torch { | ||
| try? captureDevice.lockForConfiguration() | ||
| captureDevice.torchMode = .on | ||
| captureDevice.unlockForConfiguration() |
There was a problem hiding this comment.
curious if lock fails, will unlock crash?
There was a problem hiding this comment.
Unlocking without existing lock doesn't crash (I've tested it without calling lock first, but I assume failed lock would behave the same), but setting torchMode without acquiring a lock does. Also, neither locking nor unlocking twice crashes either. I won't address this during the migration, but I will open an issue for it
There was a problem hiding this comment.
RobertOdrowaz
added
the
autosubmit
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/flutter
that referenced
this pull request
Jul 23, 2025
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/flutter
that referenced
this pull request
Jul 23, 2025
github-merge-queue bot
pushed a commit
to flutter/flutter
that referenced
this pull request
Jul 23, 2025
flutter/packages@9c85e5e...c5e8c82 2025-07-23 [email protected] [camera_avfoundation] Implementation swift migration - part 9 (flutter/packages#9645) 2025-07-22 [email protected] Roll Flutter from 70cdc0c to ee0cc66 (29 revisions) (flutter/packages#9662) If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/flutter-packages-flutter-autoroll Please CC [email protected] on the revert to ensure that a human is aware of the problem. To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose To report a problem with the AutoRoller itself, please file a bug: https://issues.skia.org/issues/new?component=1389291&template=1850622 Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
github-merge-queue bot
pushed a commit
to flutter/flutter
that referenced
this pull request
Jul 23, 2025
flutter/packages@9c85e5e...c5e8c82 2025-07-23 [email protected] [camera_avfoundation] Implementation swift migration - part 9 (flutter/packages#9645) 2025-07-22 [email protected] Roll Flutter from 70cdc0c to ee0cc66 (29 revisions) (flutter/packages#9662) If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/flutter-packages-flutter-autoroll Please CC [email protected] on the revert to ensure that a human is aware of the problem. To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose To report a problem with the AutoRoller itself, please file a bug: https://issues.skia.org/issues/new?component=1389291&template=1850622 Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/flutter
that referenced
this pull request
Jul 24, 2025
github-merge-queue bot
pushed a commit
to flutter/flutter
that referenced
this pull request
Jul 24, 2025
flutter/packages@9c85e5e...963550c 2025-07-23 [email protected] [google_sign_in] Add more serverClientId info to README (flutter/packages#9629) 2025-07-23 [email protected] Roll Flutter from ee0cc66 to afba7d7 (10 revisions) (flutter/packages#9665) 2025-07-23 [email protected] [camera_avfoundation] Implementation swift migration - part 9 (flutter/packages#9645) 2025-07-22 [email protected] Roll Flutter from 70cdc0c to ee0cc66 (29 revisions) (flutter/packages#9662) If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/flutter-packages-flutter-autoroll Please CC [email protected] on the revert to ensure that a human is aware of the problem. To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose To report a problem with the AutoRoller itself, please file a bug: https://issues.skia.org/issues/new?component=1389291&template=1850622 Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
azatech
pushed a commit
to azatech/flutter
that referenced
this pull request
Jul 28, 2025
…r#172696) flutter/packages@9c85e5e...963550c 2025-07-23 [email protected] [google_sign_in] Add more serverClientId info to README (flutter/packages#9629) 2025-07-23 [email protected] Roll Flutter from ee0cc66 to afba7d7 (10 revisions) (flutter/packages#9665) 2025-07-23 [email protected] [camera_avfoundation] Implementation swift migration - part 9 (flutter/packages#9645) 2025-07-22 [email protected] Roll Flutter from 70cdc0c to ee0cc66 (29 revisions) (flutter/packages#9662) If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/flutter-packages-flutter-autoroll Please CC [email protected] on the revert to ensure that a human is aware of the problem. To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose To report a problem with the AutoRoller itself, please file a bug: https://issues.skia.org/issues/new?component=1389291&template=1850622 Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
vashworth
pushed a commit
to vashworth/packages
that referenced
this pull request
Jul 30, 2025
…r#9645) Migrates camera implementation as part of flutter/flutter#119109 This PR migrates the 6th chunk of `FLTCam` class to Swift: * `startVideoRecording` * `setUpVideoRecording` * `setupWriter` Some properties of the `FLTCam` have to be temporarily made public so that they are accessible in `DefaultCamera`. ## Pre-Review Checklist **Note**: The Flutter team is currently trialing the use of [Gemini Code Assist for GitHub](https://developers.google.com/gemini-code-assist/docs/review-github-code). Comments from the `gemini-code-assist` bot should not be taken as authoritative feedback from the Flutter team. If you find its comments useful you can update your code accordingly, but if you are unsure or disagree with the feedback, please feel free to wait for a Flutter team member's review for guidance on which automated comments should be addressed. [^1]: Regular contributors who have demonstrated familiarity with the repository guidelines only need to comment if the PR is not auto-exempted by repo tooling.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Migrates camera implementation as part of flutter/flutter#119109
This PR migrates the 6th chunk of
FLTCamclass to Swift:startVideoRecordingsetUpVideoRecordingsetupWriterSome properties of the
FLTCamhave to be temporarily made public so that they are accessible inDefaultCamera.Pre-Review Checklist
[shared_preferences]pubspec.yamlwith an appropriate new version according to the pub versioning philosophy, or I have commented below to indicate which version change exemption this PR falls under1.CHANGELOG.mdto add a description of the change, following repository CHANGELOG style, or I have commented below to indicate which CHANGELOG exemption this PR falls under1.///).If you need help, consider asking for advice on the #hackers-new channel on Discord.
Note: The Flutter team is currently trialing the use of Gemini Code Assist for GitHub. Comments from the
gemini-code-assistbot should not be taken as authoritative feedback from the Flutter team. If you find its comments useful you can update your code accordingly, but if you are unsure or disagree with the feedback, please feel free to wait for a Flutter team member's review for guidance on which automated comments should be addressed.Footnotes
Regular contributors who have demonstrated familiarity with the repository guidelines only need to comment if the PR is not auto-exempted by repo tooling. ↩ ↩2 ↩3