-
Couldn't load subscription status.
- Fork 3.4k
feat: migrate os selector to jaspr #12560
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Summary of ChangesHello @schultek, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed! This pull request undertakes a significant refactoring effort by migrating the existing operating system selection mechanism from a shortcode and imperative JavaScript to a declarative Jaspr component. This change centralizes the OS selection logic within the Jaspr framework, improving maintainability and consistency across the site's interactive elements and streamlining the codebase by removing legacy JavaScript. Highlights
Using Gemini Code AssistThe full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips. Invoking Gemini You can request assistance from Gemini at any point by creating a comment using either
Customization To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a Limitations & Feedback Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here. You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension. Footnotes
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Code Review
This pull request successfully migrates the OS selector from JavaScript to a client-side Jaspr component. The implementation is well-structured, moving the OS detection logic to a shared utility file and creating a self-contained OsSelector component. This is a great improvement. I have a couple of suggestions to enhance maintainability and accessibility in the new component.
|
Visit the preview URL for this PR (updated for commit f786d43): https://flutter-docs-prod--pr12560-feat-migrate-os-selector-1se6df89.web.app |
|
Hi Killian! Nice to see you 'round here! |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Love it, thanks @schultek!
Migrates the osSelector shortcode and js code to Jaspr.
Part pf #12548
Presubmit checklist
of 80 characters or fewer.