Skip to content

Conversation

@schultek
Copy link

Migrates the osSelector shortcode and js code to Jaspr.

Part pf #12548

Presubmit checklist

  • If you are unwilling, or unable, to sign the CLA, even for a tiny, one-word PR, please file an issue instead of a PR.
  • If this PR is not meant to land until a future stable release, mark it as draft with an explanation.
  • This PR follows the Google Developer Documentation Style Guidelines—for example, it doesn't use i.e. or e.g., and it avoids I and we (first-person pronouns).
  • This PR uses semantic line breaks
    of 80 characters or fewer.

@schultek schultek requested review from a team and sfshaza2 as code owners October 17, 2025 14:54
@schultek schultek requested a review from parlough October 17, 2025 14:55
@gemini-code-assist
Copy link
Contributor

Summary of Changes

Hello @schultek, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!

This pull request undertakes a significant refactoring effort by migrating the existing operating system selection mechanism from a shortcode and imperative JavaScript to a declarative Jaspr component. This change centralizes the OS selection logic within the Jaspr framework, improving maintainability and consistency across the site's interactive elements and streamlining the codebase by removing legacy JavaScript.

Highlights

  • Jaspr Component Migration: The existing osSelector shortcode and its associated JavaScript logic have been fully migrated to a new Jaspr OsSelector component, centralizing the functionality within the Jaspr framework.
  • New OsSelector Component: A new site/lib/src/components/os_selector.dart file has been added, introducing a StatefulComponent responsible for OS detection, managing the selected OS state, and rendering interactive OS selection buttons.
  • JavaScript Cleanup: Redundant JavaScript functions (_osNameFromId, _adjustSelectedOs, setupOsSelectors) and their invocation in site/web/assets/js/main.js have been removed, as their functionality is now handled by the Jaspr component.
  • OS Detection Utility: A new OperatingSystem enum and a getOS() function have been added to site/lib/src/util.dart to provide client-side operating system detection based on the user agent.
  • Markdown Integration Update: All relevant Markdown content files have been updated to use the new <OSSelector /> component syntax, replacing the old {% osSelector %} shortcode.
Using Gemini Code Assist

The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.

Invoking Gemini

You can request assistance from Gemini at any point by creating a comment using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands on the current page.

Feature Command Description
Code Review /gemini review Performs a code review for the current pull request in its current state.
Pull Request Summary /gemini summary Provides a summary of the current pull request in its current state.
Comment @gemini-code-assist Responds in comments when explicitly tagged, both in pull request comments and review comments.
Help /gemini help Displays a list of available commands.

Customization

To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.

Limitations & Feedback

Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here.

You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension.

Footnotes

  1. Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution.

Copy link
Contributor

@gemini-code-assist gemini-code-assist bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request successfully migrates the OS selector from JavaScript to a client-side Jaspr component. The implementation is well-structured, moving the OS detection logic to a shared utility file and creating a self-contained OsSelector component. This is a great improvement. I have a couple of suggestions to enhance maintainability and accessibility in the new component.

@flutter-website-bot
Copy link
Collaborator

flutter-website-bot commented Oct 17, 2025

Visit the preview URL for this PR (updated for commit f786d43):

https://flutter-docs-prod--pr12560-feat-migrate-os-selector-1se6df89.web.app

@sfshaza2
Copy link
Contributor

Hi Killian! Nice to see you 'round here!

Copy link
Member

@parlough parlough left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Love it, thanks @schultek!

@parlough parlough merged commit 8e8b71c into feat/jaspr-migration Oct 20, 2025
2 checks passed
@parlough parlough deleted the feat/migrate-os-selector branch October 20, 2025 06:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants