Skip to content

Conversation

@schultek
Copy link

Migrates the filtering of learning resources (at /reference/learning-resources) to Jaspr.

Part of #12548

Presubmit checklist

  • If you are unwilling, or unable, to sign the CLA, even for a tiny, one-word PR, please file an issue instead of a PR.
  • If this PR is not meant to land until a future stable release, mark it as draft with an explanation.
  • This PR follows the Google Developer Documentation Style Guidelines—for example, it doesn't use i.e. or e.g., and it avoids I and we (first-person pronouns).
  • This PR uses semantic line breaks
    of 80 characters or fewer.

@schultek schultek requested a review from parlough October 21, 2025 10:56
@schultek schultek requested review from a team and sfshaza2 as code owners October 21, 2025 10:56
@schultek schultek changed the base branch from main to feat/jaspr-migration October 21, 2025 10:56
@schultek schultek removed the request for review from sfshaza2 October 21, 2025 10:57
@gemini-code-assist
Copy link
Contributor

Summary of Changes

Hello @schultek, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!

This pull request represents a significant architectural shift, migrating the site's learning resource filtering and underlying web framework from Eleventy to Jaspr. This change involves a complete overhaul of the build and deployment processes, eliminating Node.js and npm dependencies in favor of a pure Dart-based solution. The project structure has been refactored to centralize Jaspr-related code, and numerous new components and extensions have been added to support the new framework's capabilities and maintain existing site features.

Highlights

  • Technology Stack Migration: The learning resource filtering functionality has been migrated from an Eleventy-based system to Jaspr, a Dart-based web framework.
  • Dependency Removal: Node.js and npm dependencies have been entirely removed from the project, streamlining the development environment.
  • Build and Deployment Updates: Various build and deployment configurations, including Dependabot, Nix development environment, and Cloud Build pipelines, have been updated to reflect the new Jaspr-based architecture and Dart tooling.
  • Site Structure Reorganization: The site's directory structure has been reorganized, with core site files now residing under a new 'site/' directory.
  • New Components and Extensions: A comprehensive suite of new Jaspr components (e.g., buttons, cards, chips, dropdowns, feedback, OS selectors, TOC) and page extensions (e.g., attribute processing, code block highlighting, header extraction) have been introduced to support the new framework.
Ignored Files
  • Ignored by pattern: .github/workflows/** (1)
    • .github/workflows/test.yml
Using Gemini Code Assist

The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.

Invoking Gemini

You can request assistance from Gemini at any point by creating a comment using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands on the current page.

Feature Command Description
Code Review /gemini review Performs a code review for the current pull request in its current state.
Pull Request Summary /gemini summary Provides a summary of the current pull request in its current state.
Comment @gemini-code-assist Responds in comments when explicitly tagged, both in pull request comments and review comments.
Help /gemini help Displays a list of available commands.

Customization

To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.

Limitations & Feedback

Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here.

You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension.

Footnotes

  1. Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution.

Copy link
Contributor

@gemini-code-assist gemini-code-assist bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request successfully migrates the learning resource filtering functionality from JavaScript to Jaspr client components. The new implementation is well-structured, separating the search/filter controls (LearningResourceFilters) from the filter sidebar (LearningResourceFiltersSidebar) and using a ChangeNotifier for state management between them.

My review includes a couple of suggestions to improve the implementation: one to optimize state updates to avoid unnecessary rebuilds, and another to adopt a more declarative approach for managing the filter checkboxes, which will improve maintainability by removing direct DOM manipulation.

@flutter-website-bot
Copy link
Collaborator

flutter-website-bot commented Oct 21, 2025

Visit the preview URL for this PR (updated for commit 05a58ce):

https://flutter-docs-prod--pr12578-feat-migrate-learning-resou-eyyty5ar.web.app

@schultek schultek force-pushed the feat/migrate-learning-resource-index branch from 375d364 to 82f6166 Compare October 21, 2025 11:06
@parlough parlough changed the title Feat/migrate learning resource index Migrate client interactivity of learning resource index Oct 22, 2025
Copy link
Member

@parlough parlough left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Love it!

Thanks for considering the ergonomics of the data and noticing the regressed tag functionality.

@parlough parlough merged commit c79c8e8 into feat/jaspr-migration Oct 22, 2025
2 checks passed
@parlough parlough deleted the feat/migrate-learning-resource-index branch October 22, 2025 10:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants