-
Notifications
You must be signed in to change notification settings - Fork 3.4k
Migrate client interactivity of learning resource index #12578
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Migrate client interactivity of learning resource index #12578
Conversation
Summary of ChangesHello @schultek, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed! This pull request represents a significant architectural shift, migrating the site's learning resource filtering and underlying web framework from Eleventy to Jaspr. This change involves a complete overhaul of the build and deployment processes, eliminating Node.js and npm dependencies in favor of a pure Dart-based solution. The project structure has been refactored to centralize Jaspr-related code, and numerous new components and extensions have been added to support the new framework's capabilities and maintain existing site features. Highlights
Ignored Files
Using Gemini Code AssistThe full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips. Invoking Gemini You can request assistance from Gemini at any point by creating a comment using either
Customization To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a Limitations & Feedback Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here. You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension. Footnotes
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Code Review
This pull request successfully migrates the learning resource filtering functionality from JavaScript to Jaspr client components. The new implementation is well-structured, separating the search/filter controls (LearningResourceFilters) from the filter sidebar (LearningResourceFiltersSidebar) and using a ChangeNotifier for state management between them.
My review includes a couple of suggestions to improve the implementation: one to optimize state updates to avoid unnecessary rebuilds, and another to adopt a more declarative approach for managing the filter checkboxes, which will improve maintainability by removing direct DOM manipulation.
|
Visit the preview URL for this PR (updated for commit 05a58ce): https://flutter-docs-prod--pr12578-feat-migrate-learning-resou-eyyty5ar.web.app |
375d364 to
82f6166
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Love it!
Thanks for considering the ergonomics of the data and noticing the regressed tag functionality.
Migrates the filtering of learning resources (at /reference/learning-resources) to Jaspr.
Part of #12548
Presubmit checklist
of 80 characters or fewer.