-
Notifications
You must be signed in to change notification settings - Fork 3.4k
feat: organize components #12588
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: organize components #12588
Conversation
892af74 to
f6d1da0
Compare
Summary of ChangesHello @schultek, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed! This pull request focuses on improving the component architecture of the Jaspr application by introducing a more structured and logical directory layout. It aims to enhance code organization, making it easier to locate, understand, and maintain components. Additionally, it streamlines the initialization of custom components by delegating attribute parsing directly to the component classes, reducing boilerplate in the main application file and promoting a cleaner component API. Highlights
Using Gemini Code AssistThe full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips. Invoking Gemini You can request assistance from Gemini at any point by creating a comment using either
Customization To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a Limitations & Feedback Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here. You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension. Footnotes
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Code Review
This pull request does a great job of reorganizing the components into a more logical structure, which significantly improves the project's maintainability. Moving the attribute parsing logic into the respective components is also a solid refactoring step that cleans up main.dart and adheres to the single responsibility principle. I've added a few suggestions to improve the robustness of attribute parsing in some of the newly created factory constructors and to fix a potentially broken import path. Overall, this is a very positive change for the codebase.
site/lib/src/components/common/client/download_latest_button.dart
Outdated
Show resolved
Hide resolved
|
Visit the preview URL for this PR (updated for commit befe430): https://flutter-docs-prod--pr12588-feat-organize-components-dd88h0t5.web.app |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Great cleanup! I like the fromAttributes constructors consolidating the logic into the relevant components.
Part of #12548
Reorganizes the Jaspr components to the following:
components/commoncomponents/common/clientcomponents/dartpadcomponents/layoutcomponents/pagesAlso cleans up the initialization of custom components for
jaspr_content, by moving any attribute parsing logic to the respective component.