feat: Add cancel token for darwin #1234
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Caijinglong <[email protected]>
Signed-off-by: Caijinglong <[email protected]>
Signed-off-by: Caijinglong <[email protected]>
Signed-off-by: Caijinglong <[email protected]>
Signed-off-by: Caijinglong <[email protected]>
Signed-off-by: Caijinglong <[email protected]>
Signed-off-by: Caijinglong <[email protected]>
Signed-off-by: Caijinglong <[email protected]>
# Conflicts: # CHANGELOG.md # pubspec.yaml
# Conflicts: # CHANGELOG.md
# Conflicts: # CHANGELOG.md # pubspec.yaml
There was a problem hiding this comment.
Pull Request Overview
This PR adds cancel token functionality for Darwin platforms (iOS/macOS), allowing users to cancel ongoing asset loading operations. The implementation introduces a PMCancelToken class and integrates it throughout the asset loading pipeline.
Key changes:
- Introduces
PMCancelTokenclass for managing cancellation requests - Adds
cancelTokenparameters to various asset loading methods - Implements platform-specific cancellation handling for iOS/macOS
- Makes previously private methods public (
getFile,getOriginBytes)
Reviewed Changes
Copilot reviewed 19 out of 19 changed files in this pull request and generated 4 comments.
Show a summary per file
| File | Description |
|---|---|
| lib/src/types/cancel_token.dart | New file implementing the PMCancelToken class |
| lib/src/types/entity.dart | Adds cancel token support to asset loading methods and makes some methods public |
| lib/src/managers/photo_manager.dart | Adds static methods for cancelling requests |
| lib/src/internal/plugin.dart | Implements cancel token handling and method channel modifications |
| lib/src/internal/enums.dart | Adds cancel state to PMRequestState enum |
| lib/src/internal/constants.dart | Adds cancel-related constants |
| lib/photo_manager.dart | Exports the new cancel token class |
| ios/Classes/core/PMManager.m | Implements iOS cancellation logic and request tracking |
| ios/Classes/core/PMManager.h | Updates method signatures for cancel token support |
| ios/Classes/PMResultHandler.m | Adds cancel token retrieval method |
| ios/Classes/PMResultHandler.h | Updates interface to support cancel token functionality |
| ios/Classes/PMPlugin.m | Integrates cancel token handling into plugin methods |
| README.md | Documents the new cancel functionality |
Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.
lib/src/types/cancel_token.dart
Outdated
| /// [PhotoManagerPlugin.cancelRequest]. | ||
| /// User don't need to use this. | ||
| @nonVirtual | ||
| String get key => _index.toString(); |
There was a problem hiding this comment.
The key getter returns _index.toString() but should return index.toString(). This will always return '0' since _index is a static variable that gets incremented but the getter references the class-level static variable instead of the instance variable.
Suggested change
| String get key => _index.toString(); | |
| String get key => index.toString(); |
lib/src/types/entity.dart
Outdated
| Future<typed_data.Uint8List?> _getOriginBytes({ | ||
| /// Obtain the raw data of the asset. | ||
| /// | ||
| /// **Use it with cautious** since the original data might be epic large. |
There was a problem hiding this comment.
Corrected spelling of 'cautious' to 'caution'.
Suggested change
| /// **Use it with cautious** since the original data might be epic large. | |
| /// **Use it with caution** since the original data might be epic large. |
|
I have forked this repository to add some features like getAssetsGrouped. I don't know exactly what is causing the problem, but it's definitely somewhere in this PR |
Member
|
@HenrikH96 This seems to be related to #1262 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Signed-off-by: Caijinglong [email protected]