Skip to content

Remove FN_FORMAT variable handling #21

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Remove FN_FORMAT variable handling #21

wants to merge 1 commit into from

Conversation

@riconnon
Copy link

@riconnon riconnon commented Nov 16, 2018 •
edited
Loading

FN_FORMAT is deprecated in upstream Fn. We should just always use http-stream

@riconnon riconnon requested a review from zootalures November 16, 2018 14:54
@riconnon riconnon requested a review from rdallman November 16, 2018 15:25
rdallman
rdallman approved these changes Nov 16, 2018
View reviewed changes
Copy link
Contributor

@rdallman rdallman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM but i am no authority on the node fdk - FN_LISTENER validation happens in handleHTTPStream though so should be good

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@zootalures zootalures Awaiting requested review from zootalures

1 more reviewer

@rdallman rdallman rdallman approved these changes

Reviewers whose approvals may not affect merge requirements

At least 1 approving review is required to merge this pull request.

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@riconnon @rdallman