Skip to content

Conversation

@Digenis
Copy link
Member

@Digenis Digenis commented Mar 26, 2016

(copied from the original repo -- see kachayev#78)

is_string_or_bytes checks for str instances which is correct only for python3
while in python2 the right type is basestring.

Fixes kachayev#73

Bug demo in the build after adding tests.

@jacobbridges
Copy link

Nice! Thanks for catching this issue @Digenis

@jacobbridges jacobbridges merged commit e6df7a6 into fnpy:master Mar 27, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants