fix: server start and delete interactions order #47
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
While running mock services api using
IntegrationTestwe have noticed errors in logs output caused by failed call to pact api with delete interactions request.While investigating the root cause I noticed, the
TestWithStubServicesfunction is calling api endpoint usingDeleteInteractionsfunction before pact api server is started, causing connection errors.Usually it's not causing any problems expect the errors in logs because we are removing interactions again in defer operation, anyway it's making noise in logs.
Changing order of the operations in the way we are starting pact server before deleting interactions is solving the issue.