Skip to content

Conversation

wassup05
Copy link
Contributor

@wassup05 wassup05 commented Jul 2, 2025

To prevent any indices from becoming non-positive

Cause of CI failures in #999

@jalvesz
Copy link
Contributor

jalvesz commented Jul 2, 2025

Thanks @wassup05 for this PR, seems like this was the only procedure from the interface that is not being tested. Could you add 1 test to verify its behavior in test\string\test_string_strip_chomp.f90 ?

Copy link
Member

@perazz perazz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for this PR @wassup05. I agree on @jalvesz's comment to add a simple test case before this can be merged.

@wassup05
Copy link
Contributor Author

wassup05 commented Jul 3, 2025

The recent tests failed because both sides of the .and. expression are being evaluated... I am not sure if this is the standard behaviour of Fortran or compiler specific, but the next commit should fix it either way.

@jalvesz jalvesz merged commit 41a1cfc into fortran-lang:master Jul 6, 2025
16 checks passed
@wassup05 wassup05 deleted the chomp branch July 6, 2025 14:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants