Coding style cleanups #108
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
drupol
previously approved these changes
May 15, 2022
Mostly make extensions one-per-line to match what is in Nixpkgs but while at it also use the vertical space more liberally.
configureFlags should take array but lib.optionalString will return a string when the condition is false. It only ever worked because we always run the code on PHP < 7.4 and lib.optionalString returns the argument as is when the condition is false.
Let’s just list version branches, we can always extract the required data from that. This will be especially necessary once we introduce master branch, where major component of version needs to be computed.
drupol
approved these changes
May 15, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Picked from #104