fix: fix builds on darwin for PHP <= 7.3 #203
Conversation
|
It's failing... I don't get it. @HelloWorld017 any clue? |
pkgs/phps.nix
Outdated
| "--with-libxml-dir=${prev.libxml2.dev}" | ||
| ] | ||
| ++ prev.lib.optionals (prev.lib.versionAtLeast args.version "7.3") [ | ||
| "--with-pcre-regex=${prev.pcre2.dev}" |
There was a problem hiding this comment.
checking for PCRE headers location... configure: error: Could not find pcre.h in /nix/store/r2cgszbs5mpjbrj0k28i9qa7wi7lqg15-pcre2-10.42-dev
Might be that older versions expect ${prev.pcre2.dev}/include.
There was a problem hiding this comment.
We will need to look at the configure.ac or m4 files, then.
There was a problem hiding this comment.
Then I'll happily leave this job to someone else, it's way beyond my knowledge at this moment.
There was a problem hiding this comment.
FYI, this issue is now:
There was a problem hiding this comment.
Oh, then it is looking for pcre2-config program so it likely expects the bin directory.
There was a problem hiding this comment.
Same issue:
2023-01-26T15:34:06.3265322Z configure: error: Couldn't find pcre2-config
I also noticed this, I don't know if it's related:
There was a problem hiding this comment.
As the --with-external-pcre is not recognized, the --with-pcre-regex is also added. So the error message is not relevant.
I'll take a look at the error next morning.
There was a problem hiding this comment.
I have succeeded this PR in #204 with fixes for this issue. Please take a look at it
drupol
force-pushed
the
php73/fix-builds-erratum
branch
from
f739a8c to
39f9f88
Compare
Context: #201 (comment) Related PR: #201
drupol
force-pushed
the
php73/fix-builds-erratum
branch
from
39f9f88 to
42eabd8
Compare
Context: #201 (comment)
Related PR: #201