Skip to content

fix: created two build versions #1361

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 5 commits into from
Sep 10, 2025
Merged

fix: created two build versions #1361

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
31bb076
created two build api levels
Jul 6, 2025
b3fbef1
rewrote the build to check the build for both versions
Jul 7, 2025
5642111
fix: remove duplicate script key in screenshot workflow
Jul 7, 2025
57991ed
Merge branch 'development' into build-versions
nope3472 Jul 7, 2025
cb49245
Merge branch 'development' into build-versions
mariobehling Sep 1, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
28 changes: 22 additions & 6 deletions .github/actions/android/action.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -38,7 +38,7 @@ runs:
cache: true
flutter-version-file: pubspec.yaml

- name: Build Android APK/AAB
- name: Build preApi30 APK/AAB
shell: bash
env:
STORE_PASS: ${{ inputs.STORE_PASS }}
Expand All @@ -47,13 +47,29 @@ runs:
VERSION_NAME: ${{inputs.VERSION_NAME}}
VERSION_CODE: ${{inputs.VERSION_CODE}}
run: |
flutter build apk --debug --build-name $VERSION_NAME --build-number $VERSION_CODE
flutter build apk --build-name $VERSION_NAME --build-number $VERSION_CODE
flutter build appbundle --build-name $VERSION_NAME --build-number $VERSION_CODE
flutter build apk --flavor preApi30 --debug --build-name $VERSION_NAME --build-number $VERSION_CODE
flutter build apk --flavor preApi30 --build-name $VERSION_NAME --build-number $VERSION_CODE
flutter build appbundle --flavor preApi30 --build-name $VERSION_NAME --build-number $VERSION_CODE

- name: Store APK file
- name: Build postApi30 APK/AAB
shell: bash
env:
STORE_PASS: ${{ inputs.STORE_PASS }}
ALIAS: ${{ inputs.ALIAS }}
KEY_PASS: ${{ inputs.KEY_PASS }}
VERSION_NAME: ${{inputs.VERSION_NAME}}
VERSION_CODE: ${{inputs.VERSION_CODE}}
run: |
flutter build apk --flavor postApi30 --debug --build-name $VERSION_NAME --build-number $VERSION_CODE
flutter build apk --flavor postApi30 --build-name $VERSION_NAME --build-number $VERSION_CODE
flutter build appbundle --flavor postApi30 --build-name $VERSION_NAME --build-number $VERSION_CODE

- name: Store APK files
uses: actions/upload-artifact@v4
with:
name: apk-files
path: |
build/app/outputs/flutter-apk/app-debug.apk
build/app/outputs/flutter-apk/app-preapi30-debug.apk
build/app/outputs/flutter-apk/app-preapi30-release.apk
build/app/outputs/flutter-apk/app-postapi30-debug.apk
build/app/outputs/flutter-apk/app-postapi30-release.apk
11 changes: 9 additions & 2 deletions .github/actions/screenshot-android/action.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -55,7 +55,14 @@ runs:
cache: true
flutter-version-file: pubspec.yaml

- name: Create Android Screenshots
- name: Create Android Screenshots (preApi30)
uses: reactivecircus/android-emulator-runner@v2
with:
api-level: ${{ inputs.ANDROID_EMULATOR_API }}
arch: ${{ inputs.ANDROID_EMULATOR_ARCH }}
script: flutter drive --flavor preApi30 --driver=test_integration/test_driver.dart --target=test_integration/screenshots.dart -d emulator

- name: Create Android Screenshots (postApi30)
uses: reactivecircus/android-emulator-runner@v2
with:
api-level: ${{ inputs.ANDROID_EMULATOR_API }}
Expand All @@ -66,7 +73,7 @@ runs:
emulator-options: -no-snapshot-save -no-window -gpu swiftshader_indirect -noaudio -no-boot-anim -camera-back none
disable-animations: true
script: |
DEVICE_NAME="Pixel 6" flutter drive --driver=test_integration/test_driver.dart --target=test_integration/screenshots.dart -d emulator
DEVICE_NAME="Pixel 6" flutter drive --flavor postApi30 --driver=test_integration/test_driver.dart --target=test_integration/screenshots.dart -d emulator

- name: Update Fastlane Metadata
if: ${{ github.event_name == 'push' }}
Expand Down
21 changes: 20 additions & 1 deletion .github/workflows/push.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -23,7 +23,26 @@ jobs:

- name: Common Workflow
uses: ./.github/actions/common


- name: Build preApi30 APK
run: flutter build apk --flavor preApi30 -t lib/main.dart

- name: Build postApi30 APK
run: flutter build apk --flavor postApi30 -t lib/main.dart

- name: Upload preApi30 APK
uses: actions/upload-artifact@v4
with:
name: app-preapi30-release.apk
path: build/app/outputs/flutter-apk/app-preapi30-release.apk

- name: Upload postApi30 APK
uses: actions/upload-artifact@v4
with:
name: app-postapi30-release.apk
path: build/app/outputs/flutter-apk/app-postapi30-release.apk


- name: Hydrate and Update Version
id: flutter-version
run: |
Expand Down
25 changes: 25 additions & 0 deletions README.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -155,6 +155,31 @@ For this mode it is required that both the workstation and the device are on the

Enable Wireless debugging as per the [documentation](https://developer.android.com/tools/adb#wireless-android11-command-line), then **pair** `adb pair <IP>:<PORT>` and **connect** `adb connect <IP>:<PORT>` and you should be able to find your device via `adb devices`.

## Building for Android (API Flavors)

This project uses product flavors to support both pre-Android 11 and Android 11+ devices. **You must specify a flavor when building or running for Android!**

- **For Android 10 and below:**
```sh
flutter build apk --flavor preApi30 -t lib/main.dart
flutter run --flavor preApi30 -t lib/main.dart
```
Output: `build/app/outputs/flutter-apk/app-preapi30-release.apk`

- **For Android 11 and above:**
```sh
flutter build apk --flavor postApi30 -t lib/main.dart
flutter run --flavor postApi30 -t lib/main.dart
```
Output: `build/app/outputs/flutter-apk/app-postapi30-release.apk`

If you do not specify a flavor, the build will fail due to missing `minSdkVersion` and `targetSdkVersion` in the default configuration.

**Developer Note:**
- This is a standard practice for multi-target Android projects (such as those distributed on F-Droid).
- It ensures clarity and prevents accidental builds for the wrong Android version.
- If you want extra convenience, you can create local shell scripts or aliases, e.g., `run-pre.sh` with `flutter run --flavor preApi30 -t lib/main.dart` for faster development.
- Always check the README for up-to-date build instructions.

## LICENSE

Expand Down
19 changes: 14 additions & 5 deletions android/app/build.gradle
View file
Open in desktop
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Now that minSdkVersion and targetSdkVersion are defined only inside productFlavors, the build will fail unless a flavor is explicitly specified. Isn't it ?
so you mat define a default flavor using a Gradle property or make it clear in README.md how to specify the desired flavor?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I have made a suugested change in the workfllow and updated the readme to use the correct commands

Original file line number Diff line number Diff line change
Expand Up @@ -37,16 +37,25 @@ android {
}

defaultConfig {
// TODO: Specify your own unique Application ID (https://developer.android.com/studio/build/application-id.html).
applicationId "org.fossasia.badgemagic"
// You can update the following values to match your application needs.
// For more information, see: https://docs.flutter.dev/deployment/android#reviewing-the-gradle-build-configuration.
minSdkVersion 21
targetSdkVersion flutter.targetSdkVersion
versionCode flutterVersionCode.toInteger()
versionName flutterVersionName
}

flavorDimensions "api"
productFlavors {
preApi30 {
dimension "api"
minSdkVersion 21
targetSdkVersion 29
}
postApi30 {
dimension "api"
minSdkVersion 30
targetSdkVersion 34
}
}

signingConfigs {
if (GITHUB_BUILD) {
release {
Expand Down
Loading