Skip to content

Conversation

@mariobehling
Copy link
Member

@mariobehling mariobehling commented Sep 11, 2025

Reverts #1361

Summary by Sourcery

Revert the multi-flavor Android builds by removing separate preApi30 and postApi30 configurations and consolidating the build, CI, and documentation into a single generic APK/AAB build process

Enhancements:

  • Simplify GitHub Action for Android to build a single APK and app bundle without API-specific flavors
  • Remove product flavor definitions and related configuration from android/app/build.gradle
  • Clean up push workflow to drop preApi30/postApi30 build and upload steps
  • Eliminate Android API flavor sections in README and streamline build instructions
  • Unify screenshot action to use a single drive command without specifying flavors

@sourcery-ai
Copy link
Contributor

sourcery-ai bot commented Sep 11, 2025

Reviewer's guide (collapsed on small PRs)

Reviewer's Guide

This PR reverts the multi-flavor Android build setup back to a single generic build configuration by removing preApi30/postApi30 flavors, consolidating build steps, and cleaning up related documentation and CI workflows.

Class diagram for updated Android build.gradle configuration

classDiagram
    class AndroidConfig {
        applicationId: String
        minSdkVersion: Int
        targetSdkVersion: Int
        versionCode: Int
        versionName: String
    }
    %% Flavors removed, only defaultConfig remains
    AndroidConfig <|-- DefaultConfig
Loading

File-Level Changes

Change Details Files
Consolidated Android build steps in GitHub Action
  • Renamed build step to 'Build Android APK/AAB'
  • Removed flavor-specific flags from flutter build commands
  • Deleted separate preApi30 and postApi30 build blocks
.github/actions/android/action.yml
Cleaned up flavor instructions from README
  • Removed Android API flavor section and commands
  • Deleted developer notes about preApi30/postApi30 builds
README.md
Removed flavor-based jobs from CI workflow
  • Deleted preApi30 and postApi30 build and upload steps
  • Left only common workflow and version hydration
.github/workflows/push.yml
Stripped productFlavors from Android Gradle config
  • Removed flavorDimensions and productFlavors block
  • Added default minSdkVersion and targetSdkVersion comments
android/app/build.gradle
Unified screenshot generation in GitHub Action
  • Removed separate preApi30/postApi30 emulator runs
  • Adjusted drive command to run without flavor argument
.github/actions/screenshot-android/action.yml

Possibly linked issues


Tips and commands

Interacting with Sourcery

  • Trigger a new review: Comment @sourcery-ai review on the pull request.
  • Continue discussions: Reply directly to Sourcery's review comments.
  • Generate a GitHub issue from a review comment: Ask Sourcery to create an
    issue from a review comment by replying to it. You can also reply to a
    review comment with @sourcery-ai issue to create an issue from it.
  • Generate a pull request title: Write @sourcery-ai anywhere in the pull
    request title to generate a title at any time. You can also comment
    @sourcery-ai title on the pull request to (re-)generate the title at any time.
  • Generate a pull request summary: Write @sourcery-ai summary anywhere in
    the pull request body to generate a PR summary at any time exactly where you
    want it. You can also comment @sourcery-ai summary on the pull request to
    (re-)generate the summary at any time.
  • Generate reviewer's guide: Comment @sourcery-ai guide on the pull
    request to (re-)generate the reviewer's guide at any time.
  • Resolve all Sourcery comments: Comment @sourcery-ai resolve on the
    pull request to resolve all Sourcery comments. Useful if you've already
    addressed all the comments and don't want to see them anymore.
  • Dismiss all Sourcery reviews: Comment @sourcery-ai dismiss on the pull
    request to dismiss all existing Sourcery reviews. Especially useful if you
    want to start fresh with a new review - don't forget to comment
    @sourcery-ai review to trigger a new review!

Customizing Your Experience

Access your dashboard to:

  • Enable or disable review features such as the Sourcery-generated pull request
    summary, the reviewer's guide, and others.
  • Change the review language.
  • Add, remove or edit custom review instructions.
  • Adjust other review settings.

Getting Help

@mariobehling mariobehling merged commit 619e5be into development Sep 11, 2025
2 of 6 checks passed
@mariobehling mariobehling deleted the revert-1361-build-versions branch September 11, 2025 14:09
Copy link
Contributor

@sourcery-ai sourcery-ai bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hey there - I've reviewed your changes and they look great!


Sourcery is free for open source - if you like our reviews please consider sharing them ✨
Help me be more useful! Please click 👍 or 👎 on each comment and I'll use the feedback to improve your reviews.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant