-
Notifications
You must be signed in to change notification settings - Fork 2.1k
feat(forge-inspect): add option to wrap tables to terminal width #11138
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: master
Are you sure you want to change the base?
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
thank you, I think this makes sense - CC @zerosnacks pls share your thoughts
Mind to add an unit test too?
I looked into adding test for this, but we'd have to run the command via a tty where we can set the terminal width, etc. Is that the way you want to go? @grandizzy |
Ah, if complex
ah, if complex lile this then we could just skip it |
791381d
to
7197ad4
Compare
tasked claude with it, TIL there is a |
can someone run the failed job again, its an unrelated failure |
Motivation
Sometimes huge method identifiers(usually because of big structs as arguments) make the table unreadable without wrapping. Wrapping can help with that.
Solution
Add an option
--wrap/-w
to enable wrapping of content to fit the table width to terminal width. This is a non breaking change since by default it is still unwrapped.PR Checklist