Fix/cast abi strict args #11189
Open
Fix/cast abi strict args #11189
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
simon0820s
requested review from
DaniPopes,
klkvr,
mattsse,
grandizzy,
yash-atreya and
zerosnacks
as code owners
kaxhnet
approved these changes
Aug 5, 2025
kaxhnet
approved these changes
Aug 5, 2025
zerosnacks
reviewed
Aug 5, 2025
| @@ -1809,10 +1809,7 @@ impl SimpleCast { | |||
| let func = get_func(sig)?; | |||
| match encode_function_args(&func, args) { | |||
| Ok(res) => Ok(hex::encode_prefixed(&res[4..])), | |||
| Err(e) => eyre::bail!( | |||
There was a problem hiding this comment.
Let's also handle the abi_encode_packed branch in CastSubcommand::AbiEncode
There was a problem hiding this comment.
invoked by cast abi-encode "<signature>" <value> --packed
zerosnacks
reviewed
Aug 5, 2025
| "Could not ABI encode the function and arguments. Did you pass in the right types?\nError\n{}", | ||
| e | ||
| ), | ||
| Err(e) => eyre::bail!("{}", e), |
There was a problem hiding this comment.
Suggested change
| Err(e) => eyre::bail!("{}", e), | |
| Err(e) => eyre::bail!( | |
| "Could not ABI encode the function and arguments: {}", | |
| e | |
| ), |
|
Hi @simon0820s thanks for your PR! Glad to see #5053 being fixed, the current behavior of silently accepting additional arguments can be a footgun Some small notes |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation
Fixes #5053
Solution
Add validation that arguments exactly match parameters before encode arguments and add tests for this validation.
PR Checklist