Skip to content

Fix/template initialization empty flag #11655

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Draft
wants to merge 2 commits into
base: master
Choose a base branch
from
Draft

Fix/template initialization empty flag #11655

wants to merge 2 commits into from
+11 −1

Conversation

Peponks9
Copy link
Contributor

Closes #11625

Changes

  • Added --empty flag to the forge init command on line 286 in the initialize() function
  • This ensures the template directory is initialized without any default contract files
  • Added fn initialize_default_contracts to TestProject

Tests

  • exploratory analysis ins progress to reach all tests that might fail after changes above (WIP).

@Peponks9
Modified the template initialization to use --empty
0a37dc6
@Peponks9
fix(test-utils): add --empty flag to template initialization
856ef70 
- Added --empty flag to forge init command in initialize() function
- Add initialize_default_contracts()
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@DaniPopes DaniPopes Awaiting requested review from DaniPopes DaniPopes will be requested when the pull request is marked ready for review DaniPopes is a code owner

@mattsse mattsse Awaiting requested review from mattsse mattsse will be requested when the pull request is marked ready for review mattsse is a code owner

@grandizzy grandizzy Awaiting requested review from grandizzy grandizzy will be requested when the pull request is marked ready for review grandizzy is a code owner

@yash-atreya yash-atreya Awaiting requested review from yash-atreya yash-atreya will be requested when the pull request is marked ready for review yash-atreya is a code owner

@zerosnacks zerosnacks Awaiting requested review from zerosnacks zerosnacks will be requested when the pull request is marked ready for review zerosnacks is a code owner

@onbjerg onbjerg Awaiting requested review from onbjerg onbjerg will be requested when the pull request is marked ready for review onbjerg is a code owner

@0xrusowsky 0xrusowsky Awaiting requested review from 0xrusowsky 0xrusowsky will be requested when the pull request is marked ready for review 0xrusowsky is a code owner

At least 1 approving review is required to merge this pull request.

Assignees
No one assigned
Labels
None yet
Projects
Foundry
Status: No status
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Pass --empty to foundry_test_utils::initialize
1 participant
@Peponks9